Repository navigation
feat(ios): View background UI rework - #10374
Conversation
It can be revisited on a separate PR for both platforms
|
@CatchABus Great job, I think the shadows look even better. On the other hand is it possible that the shadow grows with the animation but is not respecting the origin of the view? I think I'm seeing this behavior. This comes in relation to #10250 I have originY="0" in the view but the shadow seems to grow from 0.5 Grabacion.de.pantalla.2023-09-07.a.las.0.55.32.mov |
Tbh, I forgot to try animations with different origin. I'll check it and let you know! |
PR Checklist
What is the current behavior?
Right now, we have certain limitations regarding iOS border colors and radius, shadows, and animating views that own any of those.
What is the new behavior?
This is a series of improvements regarding iOS background shadows and borders.
Animation
Reusable native view layers
CALayerinstances won't have to be recreated when background gets redrawnBorders
Shadows
clipToBoundssolutions as it's nested in super layerUIScrollView
UIScrollViewwill maintain position of nestedCALayers(e.g. gradient, shadow, border)Button
backgroundColorPropertynative getter/setter as it broke existing behaviourListPicker
backgroundColorPropertynative getter/setter as it broke existing behaviourView disposal
Utils
extendPointsToTargetYCloses #10250 #9869 #6919 .
Partially fixes #6919 (needs fix for android)
Additions for #4762
Removed #9524 changes as they broke background handling
BREAKING CHANGES:
CSSShadowwas renamed intoShadowCSSValues.