☁️ Nx Cloud Report

CI is running/has finished running commands for commit 38cded4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Sent with 💌 from NxCloud.

@CatchABus I really like those changes. Looks much cleaner and efficient (all relying on NestedScrollView original behavior).
And personally I am ok with the breaking Change. Thanks for this !

@CatchABus I really like those changes. Looks much cleaner and efficient (all relying on NestedScrollView original behavior). And personally I am ok with the breaking Change. Thanks for this !

Thank you very much! I've marked it as draft for now because iOS has center alignment as default so I'll look more into this.
I've managed to alter gravity defaults but centering needs improvements.

@CatchABus and we can't have the child of the scrollview default android alignment set to center? That way it would not be a breaking change

@farfromrefug I did a bit of work about that here: 462b993

It uses the gravity defaults we already had and applies result to scroll views until built-in layout is completed. In cases where scrollview nested layout has a fixed height but its children overlap, center alignment has still got different results but I think old behaviour was also different than that of iOS.

I believe this PR needs testing with more scenarios. Also, we should consider if it was less of a trouble to keep copies of those classes like we did before.
Feel free to post results or perform any changes that you see fit.

@CatchABus This looks great, but I am a little confused, does it contain a breaking change ? I do see differences in vertical alignment. ( Centering Vertically)

@CatchABus This looks great, but I am a little confused, does it contain a breaking change ? I do see differences in vertical alignment. ( Centering Vertically)

I'm trying to imitate old layout behaviour as much as possible but patch might still be lacking few things.
Could you post your case? Screenshots should be good too.

New plain typescript app, wrap stackLayout in ScrollView i.e.

<Page xmlns="http://schemas.nativescript.org/tns.xsd" navigatingTo="navigatingTo">
    <ActionBar title="My App" icon="" />
    <ScrollView >
    <StackLayout class="p-20">
        <Label text="Tap the button" class="h1 text-center" />
        <Button text="TAP" tap="{{ onTap }}" class="-primary" />
        <Label text="{{ message }}" class="h2 text-center" textWrap="true" />
    </StackLayout>
    </ScrollView>
</Page>

before:

with new:

@jcassidyav I committed 2 fixes, one of which solves the problem you described.
Let me know if you see any other strange issue.

New changes have caused one of HorizontalScrollView tests to break so I'm still investigating a few things.

@CatchABus Another odd one, when a scroll view is used inside a @nativescript-community/ui-material-tabs , it no longer scrolls. No errors it just won't respond to a touch to scroll it.

e.g. https://stackblitz.com/edit/nativescript-stackblitz-templates-dgf6vd?file=app/main-page.xml

@farfromrefug @jcassidyav I close this in favor of #10213 . Layout rework gave me trouble because of how it currently works in {N} so I focused solely on exception fix.
We could retry this sometime in the future. Thank you very much for your assistance!