Skip to content

fix(core): ScrollView event wiring sequencing improvement - #10178

Merged
NathanWalker merged 2 commits into
mainfrom
fix/scroll-events
Jan 19, 2023
Merged

NathanWalker merged 2 commits into
mainfrom
fix/scroll-events

Conversation

@NathanWalker

Copy link
Copy Markdown
Contributor

PR Checklist

What is the current behavior?

Event wiring sequencing prevented the scroll event from attaching under setup conditions.

What is the new behavior?

Scroll event works as normal.

cc/ @asharghi

@nx-cloud

nx-cloud Bot commented Jan 19, 2023 •

Copy link
Copy Markdown

☁️ Nx Cloud Report

CI is running/has finished running commands for commit dc7f56b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@cla-bot cla-bot Bot added the cla: yes label Jan 19, 2023
@NathanWalker
NathanWalker requested a review from rigor789 January 19, 2023 18:11
rigor789
rigor789 previously approved these changes Jan 19, 2023

@rigor789 rigor789 left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - we can revisit adding scroll listeners after the view has been created as a broader topic...

Edit: seems like some tests fail...

@NathanWalker
NathanWalker merged commit 75821ea into main Jan 19, 2023
@NathanWalker
NathanWalker deleted the fix/scroll-events branch January 19, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants