Repository navigation
fix(android): Method openUrl failed to handle urls - #10161
Merged
Merged
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f4c6d0c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
|
@CatchABus Verified your changes, and it works as expected. |
prabudevarrajan1
approved these changes
Jan 6, 2023
NathanWalker
approved these changes
Jan 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Method
openUrlfails to handle certain http/https schemas (e.g. YouTube links).What is the new behavior?
This patch partially reverts changes in #10148 as they triggered this problem.
We could start adding checks for http/https schemas but we really don't have to make it too complicated.
@prabudevarrajan You should face no problems as your change in
WebViewis sufficient for fixing your bug. You can also try and let us know.Fixes: https://discord.com/channels/603595811204366337/603595811720527881/1060924012919799888