Skip to content

fix(ios): TextField keyboard handling with emoji, autofill, and shortcuts - #10154

Merged
NathanWalker merged 3 commits into
mainfrom
fix/ios-text-input-handling
Jan 4, 2023
Merged

NathanWalker merged 3 commits into
mainfrom
fix/ios-text-input-handling

Conversation

@NathanWalker

Copy link
Copy Markdown
Contributor

PR Checklist

What is the current behavior?

Emoji input and/or keyboard shortcuts were not handled properly.

What is the new behavior?

Keyboard handling is stable under all diverse cases. Added forms page to toolbox to confirm this behavior.

closes #10108

@nx-cloud

nx-cloud Bot commented Jan 4, 2023 •

Copy link
Copy Markdown

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1dc5e57. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@cla-bot cla-bot Bot added the cla: yes label Jan 4, 2023
@triniwiz
triniwiz self-requested a review January 4, 2023 00:47

@triniwiz triniwiz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@NathanWalker
NathanWalker merged commit 00944bb into main Jan 4, 2023
@NathanWalker
NathanWalker deleted the fix/ios-text-input-handling branch January 4, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IOS, whole string is replaced by emoji or .com

2 participants