Skip to content

fix(android): Fixes web-view handling url (#10147) #10148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NathanWalker merged 8 commits into from
Jan 4, 2023
Merged

fix(android): Fixes web-view handling url (#10147) #10148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6c973e4
fix(android): Fixes web-view handling url (#10147)
prabudevarrajan1 Dec 29, 2022
ddd1d6c
fix(android) - web-view avoid circular imports
prabudevarrajan1 Dec 29, 2022
79ce1a5
fix(android): openUrl special URL handling
prabudevarrajan Dec 29, 2022
f5d246e
Merge branch 'main' into master
prabudevarrajan Dec 29, 2022
9c6d3e0
chore(android): Updated the trace log message
prabudevarrajan Dec 30, 2022
f63ae19
Merge branch 'master' of github-personal:prabudevarrajan/NativeScript
prabudevarrajan Dec 30, 2022
5116cc5
Merge branch 'main' into master
NathanWalker Jan 4, 2023
e2d9154
Merge branch 'main' into master
NathanWalker Jan 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/core/ui/web-view/index.android.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@ function initializeWebViewClient(): void {

// Handle schemes like mailto, tel, etc
if (!android.webkit.URLUtil.isNetworkUrl(url)) {
openUrl(url);
return true;
return openUrl(url);
}

return false;
Expand Down
8 changes: 8 additions & 0 deletions packages/core/utils/index.android.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,16 @@ export function openUrl(location: string): boolean {
const context = ad.getApplicationContext();
try {
const intent = new android.content.Intent(android.content.Intent.ACTION_VIEW, android.net.Uri.parse(location.trim()));
const packageManager = context.getPackageManager();

intent.addFlags(android.content.Intent.FLAG_ACTIVITY_NEW_TASK);

// Handle schemes like mailto, tel, etc
if (intent.resolveActivity(packageManager) == null) {
Comment thread
prabudevarrajan marked this conversation as resolved.
Resolved
Trace.write('Unable to open ' + location + '. Make sure to add queries element(https://developer.android.com/guide/topics/manifest/queries-element) matching the scheme to the AndroidManifest.xml file.', Trace.categories.Error, Trace.messageType.error);
return false;
}

context.startActivity(intent);
} catch (e) {
// We Don't do anything with an error. We just output it
Expand Down