Repository navigation
fix(android): Migration step for ApplicationSettings.getNumber - #10140
Merged
NathanWalker merged 1 commit intoDec 21, 2022
Merged
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 6c85fe5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
|
Wow, that's a quick fix, good job! This is the best way to ensure backwards compatibility and should take care of all cases. Thanks! |
NathanWalker
approved these changes
Dec 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
It seems that my SharedPreferences fix in #10094 has caused trouble for apps that have old float values stored because Java fails to cast Float to Long.
What is the new behavior?
Added a migration step to store the outdated values anew in proper format.
Fixes/Implements/Closes #10139 .
@Semurak I believe this takes care of the problem. Let me know if you think there's a case we don't cover.