perf(android): reduce java object creation#10129
Merged
NathanWalker merged 4 commits intomainfrom Feb 21, 2023
Merged
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit ae6ff0e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Collaborator
|
@triniwiz can't you even make them static as you only use them in draw ? |
Member
Author
|
@farfromrefug possible but, I'll need to run some more tests 😅 |
NathanWalker
approved these changes
Dec 21, 2022
NathanWalker
previously approved these changes
Feb 16, 2023
NathanWalker
approved these changes
Feb 21, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aims to reduce object creation when updating border or background properties