☁️ Nx Cloud Report

CI is running/has finished running commands for commit ccfa6ed. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Sent with 💌 from NxCloud.

A test failed in the original PR (#10096), as well as here:

Test: TAB-VIEW-ROOT.test_offset_zero_should_raise_same_events FAILED:  At /0/2 
  actual:   'Tab0 Frame0 Page0 navigatingTo' and 
  expected: 'Tab0 Frame0 Page0 loaded'       differ.

I believe the actual is now expected - but the test has not been updated to reflect that. Other than that - wouldn't loaded need to be called as well?

Tab0 Frame0 Page0 navigatingTo loaded

(haven't looked at the actual test, just looking at the failed test in CI)

Looking at the test, these are not a sequence, but actual events - so just probably need to change the assertions.

@rigor789 the change in frame should NOT be reverted! I need to fox this

@rigor789 @NathanWalker i fixed this correctly now by only adding the notify of the event for the Frame.
I also added a comment to explain the situation and the emphasis on the fact that all that should be refactored / fixed. To me it seems iOS does not send those events at the right time.

I also added navigation tests back (only some as others were failing) and added tests for the Frame events

nicely done @farfromrefug thank you!