Skip to content

fix(core): frame navigatingTo event were not fired on iOS #10096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NathanWalker merged 3 commits into from
Nov 18, 2022
Merged

fix(core): frame navigatingTo event were not fired on iOS #10096

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f1f443
fix(core): frame `navigatingTo` event were not fired on iOS
farfromrefug Nov 18, 2022
dffe58f
Merge branch 'main' into farfromrefug-patch-1
NathanWalker Nov 18, 2022
fff4a72
fix(ios): navigatingTo event handling
NathanWalker Nov 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/ui/frame/index.ios.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ export class Frame extends FrameBase {
}

public _onNavigatingTo(backstackEntry: BackstackEntry, isBack: boolean) {
//
super._onNavigatingTo(backstackEntry, isBack);
}
}

Expand Down
7 changes: 0 additions & 7 deletions packages/core/ui/page/index.ios.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,13 +118,6 @@ class UIViewControllerImpl extends UIViewController {
}

const frame = this.navigationController ? (<any>this.navigationController).owner : null;
const newEntry = this[ENTRY];

// Don't raise event if currentPage was showing modal page.
if (!owner._presentedViewController && newEntry && (!frame || frame.currentPage !== owner)) {
const isBack = isBackNavigationTo(owner, newEntry);
owner.onNavigatingTo(newEntry.entry.context, isBack, newEntry.entry.bindingContext);
}

if (frame) {
if (!owner.parent) {
Expand Down