Skip to content

fix(android): ApplicationSettings not returning precise stored numbers #10094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NathanWalker merged 1 commit into from
Nov 17, 2022
Merged

fix(android): ApplicationSettings not returning precise stored numbers #10094

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/core/application-settings/index.android.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ export function getString(key: string, defaultValue?: string): string {
export function getNumber(key: string, defaultValue?: number): number {
verify(key);
if (hasKey(key)) {
return sharedPreferences.getFloat(key, float(0.0));
// SharedPreferences has no getter or setter for double so use long instead
return java.lang.Double.longBitsToDouble(sharedPreferences.getLong(key, long(0)));
}

return defaultValue;
Expand All @@ -68,7 +69,8 @@ export function setNumber(key: string, value: number): void {
verify(key);
common.ensureValidValue(value, 'number');
const editor = sharedPreferences.edit();
editor.putFloat(key, float(value));
// SharedPreferences has no getter or setter for double so use long instead
editor.putLong(key, java.lang.Double.doubleToRawLongBits(double(value)));
editor.apply();
}

Expand Down