Skip to content

fix: wrong check on isRunningLayout #10078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NathanWalker merged 3 commits into from
Nov 9, 2022
Merged

fix: wrong check on isRunningLayout #10078

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4f20b6
fix: wrong check on isRunningLayout
edusperoni Nov 8, 2022
0d91018
Merge branch 'main' into fix/isRunningLayout-check
NathanWalker Nov 8, 2022
dec0d22
Merge branch 'main' into fix/isRunningLayout-check
NathanWalker Nov 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/core/ui/page/index.ios.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,10 @@ class UIViewControllerImpl extends UIViewController {

public isBackstackSkipped: boolean;
public isBackstackCleared: boolean;
private _isRunningLayout = 0;
// this is initialized in initWithOwner since the constructor doesn't run on native classes
private _isRunningLayout: number;
private get isRunningLayout() {
return this._isRunningLayout === 0;
return this._isRunningLayout !== 0;
}
private startRunningLayout() {
this._isRunningLayout++;
Expand All @@ -96,6 +97,7 @@ class UIViewControllerImpl extends UIViewController {
public static initWithOwner(owner: WeakRef<Page>): UIViewControllerImpl {
const controller = <UIViewControllerImpl>UIViewControllerImpl.new();
controller._owner = owner;
controller._isRunningLayout = 0;

return controller;
}
Expand Down