Repository navigation
fix: wrong check on isRunningLayout - #10078
Merged
Merged
Conversation
NathanWalker
approved these changes
Nov 8, 2022
edusperoni
added a commit
that referenced
this pull request
Nov 9, 2022
NathanWalker
pushed a commit
that referenced
this pull request
Nov 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix on top of #10044 according to @CatchABus comments.
Turns out that setting the number to 0 was not working because iOS doens't call the constructor (uses alloc().init()) so the number started with undefined and then became NaN, which would make
isRunningLayoutalways false.This now introduces the correct behavior. (doesn't change anything in practice, as I've not been able to reproduce any scenario where
isRunningLayoutistrue)