Repository navigation
fix(core): iOS Tab page display issue if showing message dialog - #10075
Conversation
|
@dgmachado very interesting fix for something which have been bugging us all for a long time. Will it also apply to showing modal just after a message dialog? |
@farfromrefug this apply also to showing a message dialog just after the modal but the inverse I'm not convinced. If you have a sample app I could take a look. |
|
@dgmachado I can write one tomorrow. But I think simply opening a modal from a alert dialog button callback should trigger the issue. Just had it today (working around it with timeouts) |
|
@farfromrefug if you end up with a secondary repro on the alternate path you mention we can handle in separate PR. |
PR Checklist
What is the current behavior?
If the tabstripitem added with tap event which displays a message dialog, the tab page is not being displayed.
iOS issue detail: ".... called on <UINavigationControllerImpl 0x14580cc00> while an existing transition or presentation is occurring; the navigation stack will not be updated."
Reproduce steps:
What is the new behavior?
Check if an existing transition or presentation is occurring and push the new navigation only after the transition completion.
Example App
testPopover_tabBar3.zip