Repository navigation
fix(ios): ensure view layout when using large titles - #10044
Merged
Merged
Conversation
NathanWalker
approved these changes
Nov 2, 2022
Contributor
|
@NathanWalker This one has 2 review requests. I believe they should be looked into. |
Contributor
|
@CatchABus possible to link to those? Don't see them here. |
CatchABus
reviewed
Nov 3, 2022
CatchABus
left a comment
CatchABus
left a comment
Contributor
There was a problem hiding this comment.
Please let me know what you think about those.
edusperoni
added a commit
that referenced
this pull request
Nov 9, 2022
Co-authored-by: Nathan Walker <walkerrunpdx@gmail.com>
NathanWalker
added a commit
that referenced
this pull request
Nov 9, 2022
Co-authored-by: Nathan Walker <walkerrunpdx@gmail.com>
3 of 5 tasks
farfromrefug
added a commit
to Akylas/NativeScript
that referenced
this pull request
Mar 23, 2023
I plan on correctly fixing this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
When using large titles with a listview, you'll be unable to scroll up and reveal the large title due to us recalculating the layout on viewDidLayoutSubviews only, constatly glitching while scrolling to top.
This happens because iOS will NOT call
viewDidLayoutSubviewsin those scenarios, onlyviewSafeAreaInsetsDidChange, so there's a size mismatch and the glitch happensWhat is the new behavior?
We now recalculate the layout when safe area insets change. ListView and ScrollView users might still want to use
iosIgnoreSafeAreato avoid costly layout recalculation as those views' sizes are mostly managed by iOS once large titles are enabled.