Skip to content

[modal] ns-dark not applied to top element #8374

Closed

Description

@farfromrefug

I am using latest of everything

If you run the attached example:

  • click the button => opened page is not themed but child label is
  • change the code to open modal modalFrame/modalFrame
  • click the button => opened page is themed but child label is
    NSPlayground 2.zip

I think the issue is that the top/root view opened in modal is not applied ns-dark.

I also see that behavior in my nativescript-material-bottomsheet and nativescript-material-dialogs when i show custom view inside dialog or bottom sheet.
https://github.com/Akylas/nativescript-material-components/blob/2ed3d870bdce10e66fa2bcda4d936da499690f39/src/bottomsheet/bottomsheet-common.ts#L134
BTW it happens on both platforms

Activity

  1. NavruzbekNoraliev commented on Apr 21, 2021

    @NavruzbekNoraliev

    same issue, bottom sheet doesn't read ns dark styles

  2. Bezlepkin commented on Jul 21, 2022

    @Bezlepkin

    Same issue in modalDialog....

  3. rigor789 commented on May 12, 2023

    @rigor789
    Member

    Fixed in #10201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions