TextView Support For maxLines and minLines #4315

Activity

1. NickIliev

   added

   os: android

   question

   severity: low

   feature

   help wanted

   and removed

   os: android

   question

   on Jun 5, 2017
2. NickIliev commented on Jun 6, 2017

   

   NickIliev

   on Jun 6, 2017

   Last edited by NickIliev

   Contributor

   More actions

   Hey, @Ericky14 you can implement your logic for creating maxLines / minLines rules for your TextView.
   nativeScript allows you to work directly with the native APIs (Android and iOS) so you can extend the logic just as you would do in a native project.
   Behind TextView stands android.widget.EditText for Android and UITextView for iOS, that said we ca use some native techniques to limit the number of lines.
   e.g.

   let tv = <TextView>page.getViewById("tv");
   tv.text = "sample text";
   
   if (isAndroid) {
       let tvAndriod = tv.android;
       tvAndriod.inputType = "text";
       tvAndriod.maxLines = "3";
   } else if (isIOS) {
       tv.ios.textContainer.maximumNumberOfLines = 3;
       tv.ios.textContainer.lineBreakMode = NSLineBreakByTruncatingTail;
   }
   
   tv.on("textChange", () => {
       if (isAndroid) {
           if (tv.android.getLayout().getLineCount() > 3) {
               tv.android.getText().delete(tv.android.getText().length() - 1, tv.android.getText().length());
           }
       }
   })
   

   Demonstration project can be found here.

   Thank you for your feature request - as a side note, I want to mention that NativeScript is open-source and everyone can become a contributor to the project. If you are interested in this option and you have a tested solution you can go through our contributing guide here.
3. bhavincb commented on Jun 6, 2018

   

   bhavincb

   on Jun 6, 2018

   More actions

   hey @NickIliev ,i would like to implement this to nativescript. but i have some doubts. where can i address them?
4. NickIliev commented on Jun 6, 2018

   

   NickIliev

   on Jun 6, 2018

   Last edited by NickIliev

   Contributor

   More actions

   @bhavincb this is what you need to create a PR - there is also a code convention guide included and development workflow. Create your PR with the codebase and test and the PR will be reviewed and if needed there will be a requests for changes.

   Of course, the best practice would be to discuss the possible code feature or changes here in this very same issue.
5. bhavincb commented on Jun 6, 2018

   

   bhavincb

   on Jun 6, 2018

   More actions

   @NickIliev, i want to add maxLines for android we can directly implement it in TextBase because it uses android.widget.TextView. but for ios TextBase uses UITextField | UITextView | UILabel | UIButton out of which UITextField doesn't support more than one line.
   so my issue is where to write logic. is there any common approach available. or should i implement it in TextView, Label and Button separately.
6. NickIliev

   added

   good first issue

   on Jun 6, 2018
7. LeoDupont commented on Jul 10, 2018

   

   LeoDupont

   on Jul 10, 2018

   More actions

   @bhavincb, @NickIliev, do you have any news about this feature?
8. bhavincb commented on Jul 10, 2018

   

   bhavincb

   on Jul 10, 2018

   More actions

   @LeoDupont for now you can use workaround provided by Nichlliev.
9. radeva

   added

   hacktoberfest

   on Oct 1, 2018
10. codewithbjim commented on Aug 8, 2019

    

    codewithbjim

    on Aug 8, 2019

    Last edited by codewithbjim

    More actions

    Is there any workaround for having a scrollable textview after a certain number of lines?
    I implemented @NickIliev workaround and it no longer accepts any input after reaching the maximum number of lines.

    And right now, max-height is not yet implemented which is the possible workaround for having a scrollable textview.
11. dtopuzov

    closed this as completedin #7943on Jan 16, 2020