Skip to content

Commit f6df7e5

Browse files
committed
fix(ios-tabs): a crash on swiping a content item
Fixes #7459.
1 parent 08abbac commit f6df7e5

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

‎tns-core-modules/ui/tabs/tabs.ios.ts‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@ class UIPageViewControllerDataSourceImpl extends NSObject implements UIPageViewC
287287
const owner = this._owner.get();
288288
let selectedIndex = owner.selectedIndex;
289289

290-
if (selectedIndex === 2) {
290+
if (selectedIndex === owner.items.length - 1) {
291291
return null;
292292
}
293293

@@ -352,7 +352,7 @@ class UIPageViewControllerDelegateImpl extends NSObject implements UIPageViewCon
352352
//
353353
}
354354

355-
public pageViewControllerDidFinishAnimatingPreviousViewControllersTransitionCompleted(pageViewController: UIPageViewController, didFinishAnimating: boolean, previousViewControllers: NSArray<UIViewController>, transitionCompleted: boolean): void {
355+
public pageViewControllerDidFinishAnimatingPreviousViewControllersTransitionCompleted(pageViewController: UIPageViewController, didFinishAnimating: boolean, previousViewControllers: NSArray<UIViewController>, transitionCompleted: boolean): void {
356356
if (!transitionCompleted) {
357357
return;
358358
}
@@ -366,7 +366,7 @@ class UIPageViewControllerDelegateImpl extends NSObject implements UIPageViewCon
366366
if (selectedIndex !== nextViewControllerIndex) {
367367
owner.selectedIndex = nextViewControllerIndex;
368368
}
369-
369+
370370
console.log("test");
371371
//
372372
}
@@ -812,7 +812,7 @@ export class Tabs extends TabsBase {
812812

813813
// items.forEach((item, i) => {
814814
// const controller = this.getViewController(item);
815-
815+
816816
// let icon = null;
817817
// let title = "";
818818

@@ -1038,4 +1038,4 @@ export class Tabs extends TabsBase {
10381038
// function applyStatesToItem(item: UITabBarItem, states: TabStates) {
10391039
// item.setTitleTextAttributesForState(states.normalState, UIControlState.Normal);
10401040
// item.setTitleTextAttributesForState(states.selectedState, UIControlState.Selected);
1041-
// }
1041+
// }

0 commit comments

Comments
 (0)