Ability to load local files in a WebView on iOS devices (#4444)

EddyVerbruggen · Alexander Vakrilov · commit f399f6c62bdd · 2017-06-28T11:00:02.000+03:00
* Ability to load local files in a WebView on iOS devices

* Ability to load local files in a WebView on iOS devices (removed doc-comments in test)
diff --git a/tests/app/ui/web-view/test with spaces.html b/tests/app/ui/web-view/test with spaces.html
@@ -0,0 +1,10 @@
+﻿<!DOCTYPE html>
+<html>
+<head>
+    <title>MyTitle</title>
+	<meta charset="utf-8" />
+</head>
+<body>
+    <span style="color:red">TestÖ with Spaces</span>
+</body>
+</html>
diff --git a/tests/app/ui/web-view/web-view-tests.ts b/tests/app/ui/web-view/web-view-tests.ts
@@ -87,6 +87,40 @@ export class WebViewTest extends testModule.UITest<webViewModule.WebView> {
         // << webview-localfile
     }
 
+    public testLoadLocalFileWithSpaceInPath(done) {
+        let webView = this.testView;
+
+        webView.on(webViewModule.WebView.loadFinishedEvent, function (args: webViewModule.LoadEventData) {
+            let actual;
+            let expectedTitle = 'MyTitle';
+            let expectedHtml = '<span style="color:red">TestÖ with Spaces</span>';
+
+            if (webView.ios) {
+                actual = webView.ios.stringByEvaluatingJavaScriptFromString("document.body.innerHTML").trim();
+            } else if (webView.android) {
+                actual = webView.android.getTitle();
+            }
+
+            try {
+                TKUnit.assertNull(args.error, args.error);
+                TKUnit.assertEqual(actual, webView.ios ? expectedHtml : expectedTitle, "File ~/ui/web-view/test.html not loaded properly.");
+                done(null);
+            }
+            catch (e) {
+                done(e);
+            }
+
+            let message;
+            if (!args.error) {
+                message = "WebView finished loading " + args.url;
+            }
+            else {
+                message = "Error loading " + args.url + ": " + args.error;
+            }
+        });
+        webView.src = "~/ui/web-view/test with spaces.html";
+    }
+
     public testLoadHTMLString(done) {
         let webView = this.testView;
 
diff --git a/tns-core-modules/ui/web-view/web-view-common.ts b/tns-core-modules/ui/web-view/web-view-common.ts
@@ -71,6 +71,11 @@ export abstract class WebViewBase extends View implements WebViewDefinition {
             src = "file://" + src;
         }
 
+        // loading local files from paths with spaces may fail
+        if (src.toLowerCase().indexOf("file:///") === 0) {
+            src = encodeURI(src);
+        }
+
         if (src.toLowerCase().indexOf("http://") === 0 ||
             src.toLowerCase().indexOf("https://") === 0 ||
             src.toLowerCase().indexOf("file:///") === 0) {
