fix(core): prevent exponential traversal in _dialogClosed and _onRootViewReset (#11220)

edusperoni · web-flow · commit d28300b78f95 · 2026-05-19T08:43:32.000-07:00
Both methods used eachDescendant to walk the full subtree, then each
visited child recursively called the same method—which walked its own
subtree again. For a tree of depth n this produced O(2^n) visits.

Replace eachDescendant with eachChild so each node is visited exactly
once via natural recursion, reducing traversal to O(n).
diff --git a/packages/core/ui/core/view-base/index.ts b/packages/core/ui/core/view-base/index.ts
@@ -1502,7 +1502,7 @@ export abstract class ViewBase extends Observable {
 	 * Method is intended to be overridden by inheritors and used as "protected"
 	 */
 	public _dialogClosed(): void {
-		eachDescendant(this, (child: ViewBase) => {
+		this.eachChild((child: ViewBase) => {
 			child._dialogClosed();
 
 			return true;
@@ -1513,7 +1513,7 @@ export abstract class ViewBase extends Observable {
 	 * Method is intended to be overridden by inheritors and used as "protected"
 	 */
 	public _onRootViewReset(): void {
-		eachDescendant(this, (child: ViewBase) => {
+		this.eachChild((child: ViewBase) => {
 			child._onRootViewReset();
 
 			return true;
