fix(action-bar-ios13): action bar items population (#7965)

manoldonev · Alexander Vakrilov · commit ce96dad398b6 · 2019-10-16T13:39:27.000+03:00
diff --git a/tns-core-modules/ui/action-bar/action-bar.ios.ts b/tns-core-modules/ui/action-bar/action-bar.ios.ts
@@ -233,20 +233,20 @@ export class ActionBar extends ActionBarBase {
 
     private populateMenuItems(navigationItem: UINavigationItem) {
         const items = this.actionItems.getVisibleItems();
-        const leftBarItems = [];
-        const rightBarItems = [];
+        const leftBarItems = NSMutableArray.new();
+        const rightBarItems = NSMutableArray.new();
         for (let i = 0; i < items.length; i++) {
             const barButtonItem = this.createBarButtonItem(items[i]);
             if (items[i].ios.position === "left") {
-                leftBarItems.push(barButtonItem);
+                leftBarItems.addObject(barButtonItem);
             } else {
-                rightBarItems.splice(0, 0, barButtonItem);
+                rightBarItems.insertObjectAtIndex(barButtonItem, 0);
             }
         }
 
         navigationItem.setLeftBarButtonItemsAnimated(<any>leftBarItems, false);
         navigationItem.setRightBarButtonItemsAnimated(<any>rightBarItems, false);
-        if (leftBarItems.length > 0) {
+        if (leftBarItems.count > 0) {
             navigationItem.leftItemsSupplementBackButton = true;
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -233,20 +233,20 @@ export class ActionBar extends ActionBarBase {`
`233`	`233`
`234`	`234`	`private populateMenuItems(navigationItem: UINavigationItem) {`
`235`	`235`	`const items = this.actionItems.getVisibleItems();`
`236`		`- const leftBarItems = [];`
`237`		`- const rightBarItems = [];`
	`236`	`+ const leftBarItems = NSMutableArray.new();`
	`237`	`+ const rightBarItems = NSMutableArray.new();`
`238`	`238`	`for (let i = 0; i < items.length; i++) {`
`239`	`239`	`const barButtonItem = this.createBarButtonItem(items[i]);`
`240`	`240`	`if (items[i].ios.position === "left") {`
`241`		`- leftBarItems.push(barButtonItem);`
	`241`	`+ leftBarItems.addObject(barButtonItem);`
`242`	`242`	`} else {`
`243`		`- rightBarItems.splice(0, 0, barButtonItem);`
	`243`	`+ rightBarItems.insertObjectAtIndex(barButtonItem, 0);`
`244`	`244`	`}`
`245`	`245`	`}`
`246`	`246`
`247`	`247`	`navigationItem.setLeftBarButtonItemsAnimated(<any>leftBarItems, false);`
`248`	`248`	`navigationItem.setRightBarButtonItemsAnimated(<any>rightBarItems, false);`
`249`		`- if (leftBarItems.length > 0) {`
	`249`	`+ if (leftBarItems.count > 0) {`
`250`	`250`	`navigationItem.leftItemsSupplementBackButton = true;`
`251`	`251`	`}`
`252`	`252`	`}`