chore: fix eslint config for typescript-eslint v8 and make nx lint core pass

NathanWalker · claude · NathanWalker · commit ce4ef5ad5156 · 2026-07-17T13:49:31.000-07:00
The config referenced @typescript-eslint/no-extra-semi, which was removed in
typescript-eslint v8, causing a rule-not-found error on every linted file.
Removing it surfaced pre-existing issues, addressed as follows:

- Disable the v8 successors of the already-disabled ban-types rule
  (no-unsafe-function-type, no-wrapper-object-types, no-empty-object-type)
  plus no-unsafe-declaration-merging (interface+class merging is a core
  NativeScript pattern), and allow short-circuit/ternary expression
  statements, matching existing code style.
- Stop linting generated iOS typings (platforms/) and the vendored css
  parser (css/lib/) in packages/core.
- Drop parserOptions.project from packages/core lint config: no type-aware
  rules are in use, and it caused parsing errors for ~20 handwritten d.ts
  files not included in any tsconfig.
- Code fixes: do..while(true) -&gt; while(true) in CSS3Parser, prefer-const in
  inspector_modules, module -&gt; namespace in file-system/trace d.ts files,
  eslint-disable for the required triple-slash reference in index.d.ts.

nx lint core, nx test core (192 passed) and nx build core all pass.

Co-Authored-By: Claude Fable 5 &lt;noreply@anthropic.com&gt;
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -39,15 +39,18 @@
 				"@typescript-eslint/no-this-alias": "warn",
 				"@typescript-eslint/no-namespace": "off",
 				"@typescript-eslint/no-inferrable-types": "off",
-				"@typescript-eslint/no-extra-semi": "error",
+				"@typescript-eslint/no-empty-object-type": "off",
+				"@typescript-eslint/no-unsafe-function-type": "off",
+				"@typescript-eslint/no-wrapper-object-types": "off",
+				"@typescript-eslint/no-unsafe-declaration-merging": "off",
+				"@typescript-eslint/no-unused-expressions": ["error", { "allowShortCircuit": true, "allowTernary": true }],
 				"no-extra-semi": "off"
 			}
 		},
 		{
 			"files": ["*.js", "*.jsx"],
 			"extends": ["plugin:@nx/javascript"],
 			"rules": {
-				"@typescript-eslint/no-extra-semi": "error",
 				"no-extra-semi": "off"
 			}
 		},
diff --git a/packages/core/.eslintrc.json b/packages/core/.eslintrc.json
@@ -1,15 +1,8 @@
 {
 	"extends": "../../.eslintrc.json",
 	"rules": {},
-	"ignorePatterns": ["!**/*", "**/global-types.d.ts", "**/node_modules/**/*", "**/__tests__/**/*", "**/vite.config.*.timestamp*", "**/vitest.config.*.timestamp*"],
+	"ignorePatterns": ["!**/*", "**/global-types.d.ts", "**/node_modules/**/*", "**/__tests__/**/*", "**/platforms/**/*", "**/css/lib/**/*", "**/vite.config.*.timestamp*", "**/vitest.config.*.timestamp*"],
 	"overrides": [
-		{
-			"files": ["*.ts", "*.tsx", "*.js", "*.jsx"],
-			"parserOptions": {
-				"project": ["packages/core/tsconfig.*?.json"]
-			},
-			"rules": {}
-		},
 		{
 			"files": ["*.ts", "*.tsx"],
 			"rules": {}
diff --git a/packages/core/css/CSS3Parser.ts b/packages/core/css/CSS3Parser.ts
@@ -669,7 +669,8 @@ export class CSS3Parser {
 			text: undefined,
 			components: [],
 		};
-		do {
+		// eslint-disable-next-line no-constant-condition
+		while (true) {
 			if (this.nextInputCodePointIndex >= this.text.length) {
 				funcToken.text = name + '(' + this.text.substring(start);
 
@@ -692,6 +693,6 @@ export class CSS3Parser {
 				}
 				// TODO: Else we won't advance
 			}
-		} while (true);
+		}
 	}
 }
diff --git a/packages/core/file-system/index.d.ts b/packages/core/file-system/index.d.ts
@@ -287,7 +287,7 @@ export class Folder extends FileSystemEntity {
 /**
  * Provides access to the top-level Folders instances that are accessible from the application. Use these as entry points to access the FileSystem.
  */
-export module knownFolders {
+export namespace knownFolders {
 	/**
 	 * Gets the Documents folder available for the current application. This Folder is private for the application and not accessible from Users/External apps.
 	 */
@@ -314,7 +314,7 @@ export module knownFolders {
 	/**
 	 * Contains iOS-specific known folders.
 	 */
-	module ios {
+	namespace ios {
 		/**
 		 * Gets the NSLibraryDirectory. Note that the folder will not be created if it did not exist.
 		 */
@@ -360,7 +360,7 @@ export module knownFolders {
 /**
  * Enables path-specific operations like join, extension, etc.
  */
-export module path {
+export namespace path {
 	/**
 	 * Normalizes a path, taking care of occurrances like ".." and "//".
 	 * @param path The path to be normalized.
diff --git a/packages/core/index.d.ts b/packages/core/index.d.ts
@@ -1,3 +1,4 @@
+// eslint-disable-next-line @typescript-eslint/triple-slash-reference
 /// <reference path="./global-types.d.ts" />
 /**
  * IMPORTANT: this is not generated automatically due to this issue:
diff --git a/packages/core/inspector_modules.ts b/packages/core/inspector_modules.ts
@@ -183,7 +183,7 @@ function remapStack(raw: string): string {
 	const lines = raw.split('\n');
 	const out = lines.map((line) => {
 		// 1) Parenthesized frame: at fn (file:...:L:C)
-		let m = /\((.+):(\d+):(\d+)\)/.exec(line);
+		const m = /\((.+):(\d+):(\d+)\)/.exec(line);
 		if (m) {
 			try {
 				const [_, file, l, c] = m;
diff --git a/packages/core/trace/index.d.ts b/packages/core/trace/index.d.ts
@@ -93,7 +93,7 @@ export namespace Trace {
 
 	export function removeEventListener(listener: TraceEventListener): void;
 
-	export module messageType {
+	export namespace messageType {
 		export const log = 0;
 		export const info = 1;
 		export const warn = 2;
@@ -103,7 +103,7 @@ export namespace Trace {
 	/**
 	 * all predefined categories.
 	 */
-	export module categories {
+	export namespace categories {
 		export const VisualTreeEvents = 'VisualTreeEvents';
 		export const Layout = 'Layout';
 		export const Style = 'Style';

Original file line number	Diff line number	Diff line change
`@@ -669,7 +669,8 @@ export class CSS3Parser {`
`669`	`669`	`text: undefined,`
`670`	`670`	`components: [],`
`671`	`671`	`};`
`672`		`- do {`
	`672`	`+ // eslint-disable-next-line no-constant-condition`
	`673`	`+ while (true) {`
`673`	`674`	`if (this.nextInputCodePointIndex >= this.text.length) {`
`674`	`675`	`funcToken.text = name + '(' + this.text.substring(start);`
`675`	`676`
`@@ -692,6 +693,6 @@ export class CSS3Parser {`
`692`	`693`	`}`
`693`	`694`	`// TODO: Else we won't advance`
`694`	`695`	`}`
`695`		`- } while (true);`
	`696`	`+ }`
`696`	`697`	`}`
`697`	`698`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+// eslint-disable-next-line @typescript-eslint/triple-slash-reference`
`1`	`2`	`/// <reference path="./global-types.d.ts" />`
`2`	`3`	`/**`
`3`	`4`	`* IMPORTANT: this is not generated automatically due to this issue:`