fix(core): rebuild nested-frame fragment when its view was destroyed on reattach

dangrima90-medirect · dangrima90-medirect · commit 5df98bdd7ca0 · 2026-05-12T18:48:01.000+02:00
Extends the _ensureEntryFragment recovery from #10713 to cover the case where the fragment object survives but its view has been destroyed. Without this, the nested frame renders blank after the parent is briefly covered and dismissed. Also guards entry.fragment = null in onDestroy so the old fragment's teardown doesn't overwrite the new reference assigned by the rebuild path.
diff --git a/packages/core/ui/frame/frame-helper-for-android.ts b/packages/core/ui/frame/frame-helper-for-android.ts
@@ -236,8 +236,15 @@ export class FragmentCallbacksImplementation implements AndroidFragmentCallbacks
 		// [nested frames / fragments] see https://github.com/NativeScript/NativeScript/issues/6629
 		// retaining reference to a destroyed fragment here somehow causes a cryptic
 		// "IllegalStateException: Failure saving state: active fragment has cleared index: -1"
-		// in a specific mixed parent / nested frame navigation scenario
-		entry.fragment = null;
+		// in a specific mixed parent / nested frame navigation scenario.
+		//
+		// Only null out entry.fragment if it still points to THIS fragment. _ensureEntryFragment
+		// may have already replaced it with a new fragment (when recovering one whose view was
+		// destroyed) — if THIS old fragment is destroyed afterwards, we must not overwrite the
+		// newer reference.
+		if (entry.fragment === fragment) {
+			entry.fragment = null;
+		}
 
 		const page = entry.resolvedPage;
 		if (!page) {
diff --git a/packages/core/ui/frame/index.android.ts b/packages/core/ui/frame/index.android.ts
@@ -84,6 +84,12 @@ export class Frame extends FrameBase {
 	private _cachedTransitionState: TransitionState;
 	private _frameCreateTimeout: NodeJS.Timeout;
 
+	// True while inside an onLoaded()-driven _ensureEntryFragment call. _ensureEntryFragment
+	// also runs from _onAttachedToWindow during outgoing navigations, where the fragment's
+	// view is null because it's being torn down on purpose — we must not rebuild it then.
+	// This flag lets _ensureEntryFragment tell the two cases apart.
+	private _pendingFragmentCheck = false;
+
 	constructor() {
 		super();
 		this._android = new AndroidFrame(this);
@@ -245,6 +251,10 @@ export class Frame extends FrameBase {
 	}
 
 	onLoaded(): void {
+		// Tell _ensureEntryFragment this pass is from onLoaded (an incoming reattach)
+		// rather than from _onAttachedToWindow during an outgoing transition. See the
+		// field declaration of _pendingFragmentCheck for why this matters.
+		this._pendingFragmentCheck = true;
 		if (this._originalBackground) {
 			this.backgroundColor = null;
 			this.backgroundColor = this._originalBackground;
@@ -274,6 +284,7 @@ export class Frame extends FrameBase {
 		// though we should not do it on app "start"
 		// or it will create a "flash" to activity background color
 		if (this._isReset && !this._attachedToWindow) {
+			this._pendingFragmentCheck = false;
 			return;
 		}
 
@@ -282,7 +293,13 @@ export class Frame extends FrameBase {
 			// so we manually check on loaded event if the fragment is not recreated and recreate it
 			const currentEntry = this._currentEntry || this._executingContext?.entry;
 			if (currentEntry) {
-				if (!currentEntry.fragment) {
+				// Rebuild if either:
+				//   (a) there is no fragment at all, or
+				//   (b) the fragment exists but its view was destroyed AND we got here via
+				//       onLoaded (not via _onAttachedToWindow during an outgoing transition,
+				//       where a null view is expected and a rebuild would be wrong).
+				const fragmentNeedsRebuild = !currentEntry.fragment || (currentEntry.fragment.getView() == null && this._pendingFragmentCheck);
+				if (fragmentNeedsRebuild) {
 					const manager = this._getFragmentManager();
 					const transaction = manager.beginTransaction();
 					currentEntry.fragment = this.createFragment(currentEntry, currentEntry.fragmentTag);
@@ -292,6 +309,7 @@ export class Frame extends FrameBase {
 				}
 			}
 
+			this._pendingFragmentCheck = false;
 			this._frameCreateTimeout = null;
 		}, 0);
 	}
