fix(database): preserve reserved characters in connection credentials - #969
Open
saksim wants to merge 1 commit into
Open
fix(database): preserve reserved characters in connection credentials#969saksim wants to merge 1 commit into
saksim wants to merge 1 commit into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building database URLs with f-strings parses reserved characters in usernames/passwords as URL delimiters. For example, p@ss/word:#?% is read as password p. This breaks both initialization and normal connections.
Use SQLAlchemy URL.create to pass connection fields directly for MySQL/PostgreSQL initialization and regular engines, and the SQLite database path. Drivers, database schemas, and dependencies are unchanged. Credentials should be supplied literally, without manual percent encoding.
Validation: 4 new MySQL/PostgreSQL credential tests fail before the fix; the SQLite compatibility test passes. The isolated upstream branch passes all 101 tests (Python 3.11, Windows with PYTHONUTF8=1). Initialization and normal connections are tested through mocked engines; a temporary SQLite database executes create/insert/select. No live MySQL/PostgreSQL service is used.
Only this connection URL issue is included. Fork tracking and CI: PR #18. Related report: saksim#8.