Skip to content

Improve error reporting and non-terminal output - #83

Merged
acollins3 merged 1 commit into
mainfrom
acollins/errors-and-terminal-output
Oct 27, 2026
Merged

acollins3 merged 1 commit into
mainfrom
acollins/errors-and-terminal-output

Conversation

@acollins3

Copy link
Copy Markdown
Collaborator
  • Raise "No kernels were profiled" when no kernel launch could be attributed to any annotation, instead of returning an empty DataFrame. With the CUPTI tool this previously failed silently when CUDA was used before the first profiled call.
  • Report the kernel count and number of runs in the "More than one kernel" error, and suggest warming up autotuned code in both kernel-count errors.
  • Explain the likely cause (no kernel launched in any annotation) when no NVIDIA Nsight Compute report is found, and include the report path.
  • Emit a RuntimeWarning with the ignored exception when an annotation with ignore_failures=True fails, instead of discarding it.
  • Only emit ANSI color and cursor-movement codes when stdout is a terminal; otherwise print the final progress bar only.
  • Fix example file names in examples/README.md and a repeated sentence in README.md.

- Raise "No kernels were profiled" when no kernel launch could be
  attributed to any annotation, instead of returning an empty DataFrame.
  With the CUPTI tool this previously failed silently when CUDA was used
  before the first profiled call.
- Report the kernel count and number of runs in the "More than one
  kernel" error, and suggest warming up autotuned code in both
  kernel-count errors.
- Explain the likely cause (no kernel launched in any annotation) when no
  NVIDIA Nsight Compute report is found, and include the report path.
- Emit a RuntimeWarning with the ignored exception when an annotation
  with ignore_failures=True fails, instead of discarding it.
- Only emit ANSI color and cursor-movement codes when stdout is a
  terminal; otherwise print the final progress bar only.
- Fix example file names in examples/README.md and a repeated sentence
  in README.md.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Alex Collins <acollins@nvidia.com>

@bastianhagedorn bastianhagedorn left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Reviewed the changes and ran 45 focused CPU tests, plus checks for progress output and ignored-exception warning and cleanup behavior. All passed.

@acollins3
acollins3 merged commit 1e1e50a into main Oct 27, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants