Repository navigation
Improve error reporting and non-terminal output - #83
Merged
Merged
Conversation
acollins3
commented
Oct 22, 2026
Collaborator
- Raise "No kernels were profiled" when no kernel launch could be attributed to any annotation, instead of returning an empty DataFrame. With the CUPTI tool this previously failed silently when CUDA was used before the first profiled call.
- Report the kernel count and number of runs in the "More than one kernel" error, and suggest warming up autotuned code in both kernel-count errors.
- Explain the likely cause (no kernel launched in any annotation) when no NVIDIA Nsight Compute report is found, and include the report path.
- Emit a RuntimeWarning with the ignored exception when an annotation with ignore_failures=True fails, instead of discarding it.
- Only emit ANSI color and cursor-movement codes when stdout is a terminal; otherwise print the final progress bar only.
- Fix example file names in examples/README.md and a repeated sentence in README.md.
- Raise "No kernels were profiled" when no kernel launch could be attributed to any annotation, instead of returning an empty DataFrame. With the CUPTI tool this previously failed silently when CUDA was used before the first profiled call. - Report the kernel count and number of runs in the "More than one kernel" error, and suggest warming up autotuned code in both kernel-count errors. - Explain the likely cause (no kernel launched in any annotation) when no NVIDIA Nsight Compute report is found, and include the report path. - Emit a RuntimeWarning with the ignored exception when an annotation with ignore_failures=True fails, instead of discarding it. - Only emit ANSI color and cursor-movement codes when stdout is a terminal; otherwise print the final progress bar only. - Fix example file names in examples/README.md and a repeated sentence in README.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Alex Collins <acollins@nvidia.com>
bastianhagedorn
approved these changes
Oct 27, 2026
bastianhagedorn
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me. Reviewed the changes and ran 45 focused CPU tests, plus checks for progress output and ignored-exception warning and cleanup behavior. All passed.
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.