Repository navigation
Support variable kernel counts per annotation execution - #74
Open
bastianhagedorn wants to merge 7 commits into
Open
bastianhagedorn wants to merge 7 commits into
bastianhagedorn wants to merge 7 commits into
Conversation
Signed-off-by: Bastian Hagedorn <bhagedorn@nvidia.com>
Collaborator
|
/ok to test 9c83553 |
Signed-off-by: Bastian Hagedorn <bhagedorn@nvidia.com>
Collaborator
|
/ok to test 34eac68 |
Signed-off-by: Bastian Hagedorn <bhagedorn@nvidia.com>
Collaborator
Author
|
/ok to test 046ae11 |
Collaborator
|
I like this approach. Makes it very clear which kernel belongs to which run. Before merging, this it conflicts with main, as PR #83 was just merged, so that will need addressed. |
acollins3
reviewed
Oct 27, 2026
acollins3
reviewed
Oct 27, 2026
acollins3
reviewed
Oct 27, 2026
acollins3
reviewed
Oct 27, 2026
acollins3
reviewed
Oct 27, 2026
acollins3
reviewed
Oct 27, 2026
acollins3
reviewed
Oct 27, 2026
acollins3
reviewed
Oct 27, 2026
Signed-off-by: Bastian Hagedorn <bhagedorn@nvidia.com>
Signed-off-by: Bastian Hagedorn <bhagedorn@nvidia.com>
hsahuja0805
reviewed
Oct 28, 2026
hsahuja0805
reviewed
Oct 28, 2026
hsahuja0805
requested changes
Oct 28, 2026
hsahuja0805
left a comment
Collaborator
There was a problem hiding this comment.
I made few comments. Overall, approach looks good to me.
I think this would also cover the scenario when different configuration execute on different GPU's. However, this still needs to be validated.
Signed-off-by: Bastian Hagedorn <bhagedorn@nvidia.com>
Collaborator
Author
|
/ok to test 7fb64b0 |
bastianhagedorn
marked this pull request as ready for review
November 12, 2026 06:29
Signed-off-by: Bastian Hagedorn <bhagedorn@nvidia.com>
Collaborator
Author
|
/ok to test d2e9ed8 |
acollins3
approved these changes
Nov 12, 2026
hsahuja0805
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configurations that launch different numbers of kernels can currently fail or silently group measurements into the wrong samples. Two and three kernels per configuration raise an error, while two and four can become two three-kernel samples.
Track each annotation execution's configuration and run in a private NVTX label, then reduce only the kernels belonging to that sample. NCU and CUPTI share the grouping path. Kernel counts may vary across configurations and repeated runs when
combine_kernel_metricsis supplied.combine_kernel_metricserror. Builtins, partials and callable objects remain supported.Saved
.ncu-repfiles now require the matching in-memoryinvocationsmapping for reprocessing. Returned results and exported CSVs remain available for later analysis. The processedKernelcolumn continues to describe the first sample's kernel sequence.Validation:
81 CPU tests pass, covering extraction/grouping, custom information, collection and transformation.
Six GPU tests pass with NCU 2026.2.1 and the same six pass with CUPTI 13.4 on an NVIDIA A40. Coverage includes 2/3 and 2/4 kernels across configurations, 2 then 4 kernels across repeated runs of one configuration, an empty middle run, annotation-scope collector alignment and the planted-pickle regression.
Black, isort and strict mypy pass across all 48 source files in a clean lint environment.
Sphinx builds with warnings treated as errors after suppressing a CUDA forward-reference warning also reproduced on unchanged main.
Multi-GPU regression: one configuration sweep alternates between two physical A100 80GB PCIe devices. Counts 2/4/3/1, two runs each: all eight raw samples have the expected kernel sequence, device collector value and aggregation. Passes with NCU 2026.2.1 and CUPTI 13.5. The test skips cleanly when fewer than two GPUs are visible.
Fresh GitHub CI is authorized and queued for the test-only revision.