ci: move cibuildwheel config out of github actions workflows and into pyproject.tomls#994
Merged
kkraus14 merged 2 commits intoNVIDIA:mainfrom Sep 23, 2025
Conversation
Contributor
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
cpcloud
commented
Sep 19, 2025
cpcloud
commented
Sep 19, 2025
Contributor
Author
|
/ok to test |
1 similar comment
Contributor
Author
|
/ok to test |
cpcloud
force-pushed
the
move-cibuildwheel-config-to-pyproject-toml
branch
from
4bb5410 to
261651b
Compare
Contributor
Author
|
/ok to test |
2 similar comments
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
cpcloud
force-pushed
the
move-cibuildwheel-config-to-pyproject-toml
branch
from
1ad4b74 to
c883a26
Compare
Contributor
Author
|
/ok to test |
2 similar comments
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
cpcloud
force-pushed
the
move-cibuildwheel-config-to-pyproject-toml
branch
from
c9c8dd2 to
3496530
Compare
Contributor
Author
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
cpcloud
force-pushed
the
move-cibuildwheel-config-to-pyproject-toml
branch
from
f0dc073 to
b748718
Compare
Contributor
Author
|
/ok to test |
rwgk
previously approved these changes
Sep 22, 2025
Collaborator
rwgk
left a comment
rwgk
left a comment
There was a problem hiding this comment.
Looks good to me, but caveat: I'm more learning than reviewing when looking through this PR.
kkraus14
reviewed
Sep 23, 2025
cpcloud
force-pushed
the
move-cibuildwheel-config-to-pyproject-toml
branch
from
b748718 to
cf7d2d8
Compare
Contributor
Author
|
/ok to test |
Contributor
Author
|
@kkraus14 Can you give this another review? |
kkraus14
approved these changes
Sep 23, 2025
|
Member
|
For posterity: a follow-up discussion happened here: https://github.com/NVIDIA/cuda-python/pull/1041/files#r2388712078 |
leofang
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves cibuildwheel config out of github actions and into corresponding pyproject.toml files.