Add logic to skip WSL tests and add cufile.json for async tests#778
Merged
rwgk merged 4 commits intoNVIDIA:mainfrom Jul 24, 2025
Merged
Add logic to skip WSL tests and add cufile.json for async tests#778rwgk merged 4 commits intoNVIDIA:mainfrom
rwgk merged 4 commits intoNVIDIA:mainfrom
Conversation
Contributor
rwgk
reviewed
Jul 24, 2025
Collaborator
rwgk
left a comment
rwgk
left a comment
There was a problem hiding this comment.
You can run the pre-commit tests locally with this command:
pre-commit run --all-files
cuda_bindings/tests/test_cufile.py
Outdated
| test_dir = os.path.dirname(os.path.abspath(__file__)) | ||
| config_path = os.path.join(test_dir, 'cufile.json') | ||
|
|
||
| print(f"Using cuFile config: {config_path}") |
Collaborator
There was a problem hiding this comment.
Could you please use logging?
This was generated by ChatGPT (I didn't test it):
import logging
logger = logging.getLogger(__name__)
@pytest.fixture
def cufile_env_json():
"""Set CUFILE_ENV_PATH_JSON environment variable for async tests."""
original_value = os.environ.get('CUFILE_ENV_PATH_JSON')
# Use /etc/cufile.json if it exists, otherwise fallback to cufile.json in tests directory
if os.path.exists('/etc/cufile.json'):
config_path = '/etc/cufile.json'
else:
test_dir = os.path.dirname(os.path.abspath(__file__))
config_path = os.path.join(test_dir, 'cufile.json')
logger.info(f"Using cuFile config: {config_path}")
os.environ['CUFILE_ENV_PATH_JSON'] = config_path
yield
if original_value is not None:
os.environ['CUFILE_ENV_PATH_JSON'] = original_value
else:
os.environ.pop('CUFILE_ENV_PATH_JSON', None)
Collaborator
|
/ok to test d142472 |
This comment has been minimized.
This comment has been minimized.
- Add @cache to isSupportedFilesystem(), cufileLibraryAvailable(), and cufileVersionLessThan() to avoid redundant checks and repeated INFO log messages - Set fixture scope for cufile_env_json to "module" to reduce env var churn
Collaborator
|
/ok to test |
Contributor
@rwgk, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/ |
Collaborator
|
/ok to test 8916e8a |
Collaborator
|
Merging, after off-line sync with @sourabgupta3 |
|
leofang
added
P1
leofang
pushed a commit
to leofang/cuda-python
that referenced
this pull request
Aug 4, 2025
Made obsolete by NVIDIA#778
leofang
added a commit
that referenced
this pull request
Aug 6, 2025
* Propagate generated path finder changes * Rebase to 13.0 RC14 * Update license headers on examples * Regenerate after merging upstream * Update benchmarks and run pre-commit * cython-gen output, NO manual changes * Bump cuda/bindings/_version.py → 13.0.0 * `path_finder` and cybind updates for CTK 13.0 (#81) * Update SUPPORTED_WINDOWS_DLLS: kitpicks/cuda-r13-0/13.0.0/013/local_installers/cuda_13.0.0_windows.exe * Update SUPPORTED_LINUX_SONAMES: kitpicks/cuda-r13-0/13.0.0/013/local_installers/cuda_13.0.0_580.31_linux.run * 013 → 014: SUPPORTED_LINUX_SONAMES unchanged * 013 → 014: SUPPORTED_WINDOWS_DLLS unchanged * cybind update with 13.0.0 headers (014) * Bump cuda/bindings/_version.py → 13.0.0 * test_nvjitlink.py: remove sm_60, add sm_100 * Updates from cybind after removing all 11.x headers (affects "automatically generated" comments only). * Add new toolshed/reformat_cuda_enums_as_py.py (reads cuda.h, driver_types.h headers directly). * Use new toolshed/reformat_cuda_enums_as_py.py to regenerate driver_cu_result_explanations.py, runtime_cuda_error_explanations.py * Use `driver.cuDeviceGetUuid()` instead of `driver.cuDeviceGetUuid_v2()` with CTK 13. * Adjustments for locating nvvm directory in CTK 13 installations. * Fixes from windows testing (#89) * Add missing error handling (tests/test_nvjitlink.py) * Add missing `const` in cudaMemcpyBatchAsync call (cuda/bindings/runtime.pyx.in) * Add qa/13.0.0/01_linux.sh * Remove qa/13.0.0/01_linux.sh after it was moved to a new upstream qa branch. * Strictly correct casts for cudaMemcpyBatchAsync (generated by cython_gen). * Pragmatic minimal fix for cudaMemcpyBatchAsync casts (works with Linux and Windows). (generated with cython-gen) * print *prog pointers in nvrtcCreateProgram, nvrtcCompileProgram bindings * Remove stray `"nvrtc64_*_0.alt.dll"` entries in `SUPPORTED_WINDOWS_DLLS` * Revert "print *prog pointers in nvrtcCreateProgram, nvrtcCompileProgram bindings" This reverts commit 104abbd. * _find_lib_dir_using_cuda_home(): Windows CTK 13 → bin\x64 * getLocalRuntimeVersion(): Search for libcudart.so.13 * SUPPORTED_LINUX_SONAMES: Add CTK 13 soname values * Update path_finder/supported_libs.py from kitpicks 13.0.0/025 (#96) * Linux update from cuda_13.0.0_580.46_kitpicks025_linux.run: no-op b/o NVIDIA/cuda-python-private#95 * Windows update from cuda_13.0.0_kitpicks025_windows.exe * This trivial change should have been included in PR #81, but was overlooked. Direct commit for simplicity. * cuda_core forward compatibility changes (private development branch) (#94) * CCCL_INCLUDE_PATH fixes in test_event.py, test_launcher.py * Add new file (accidentally missing in a prior commit). * Fix pre-commit errors in new tests/helpers.py * 12→13 compatibility fixes in cuda/core/experimental/_graph.py * CTK 12 compatibility (tests/test_cuda_utils.py) * Make the cuda/core/experimental/_graph.py changes backwards compatible. * Do not try to hide `13` in cuda_core/tests/test_cuda_utils.py * More elegant handling of `CCCL_INCLUDE_PATHS` in cuda_core/tests/helpers.py * Remove stray empty line (cuda_core/tests/conftest.py). * Fix logic error computing CCCL_INCLUDE_PATHS in cuda_core/tests/helpers.py * Fix `cuda_bindings` and `cuda_core` examples (#98) * Unmask globalToShmemAsyncCopy_test.py error: explicit pytest_skipif_cuda_include_not_found(), pytest_skipif_compute_capability_too_low() * Update cuda_bindings/examples/common/common.py for CTK 13 compatibility, to fix globalToShmemAsyncCopy_test.py * Update cuda_core/examples/thread_block_cluster.py for CTK 13 compatibility. * Update driver_cu_result_explanations.py, runtime_cuda_error_explanations.py (#100) * kitpicks/cuda-r13-0/13.0.0/033: CUDA_HOME=/usr/local/cuda python cython_gen.py --target-lib driver runtime nvrtc --out ../unreleased-13.0 (#107) * Update cuda_pathfinder supported_nvidia_libs.py from kitpicks 13.0.0/036 (NO CHANGES compared to 025) * Update driver_cu_result_explanations.py, runtime_cuda_error_explanations.py from kitpicks 13.0.0/036 (NO CHANGES compared to 025) * Update cuda_pathfinder supported_nvidia_libs.py EXPECTED_LIB_SYMBOLS for libnpp* The newly chosen symbols appear in all CTK 12.x releases and 13.0.0: https://gitlab-master.nvidia.com/rgrossekunst/rwgk_config_nvidia/-/blob/a1c2f29decd9b93fc7af9611bdc60565446b0cd3/bin/check_libnpp_symbols.sh * cython-gen changes due to PR #101 (#115) * cython-gen changes due to release_gil_revert_leos_commits_fix_cast_error (#116) * cython-gen changes due to cython-gen PR #118 (#120) * test_cufile.py: pytest.skip("NEEDS DEBUGGING (unreleased-13.0)") * cython-gen changes on top of `git merge world-main -X ours` product. * Add missing imports (related to #769). These got lost due to merging with `-X ours` * Revert obsolete aec7d10 Made obsolete by #778 * Remove cuda_bindings/site-packages entirely. * Change test_batch_io_large_operations to avoid a flood of output (`assert read_data == expected_data` failure). * Remove `(scope="module")` from `cufile_env_json` fixture: resolves test_batch_io_large_operations failure. * [unreleased-13.0] `test_cufile.py`: Remove fallback to `/etc/cufile.json` (#126) * test_cufile.py: NEVER USE /etc/cufile.json * Remove /etc/cufile.json code entirely. * update win driver to 580.88 * change backport branch to 12.9.x * update build ver to 13.0.0 * crt headers are now split from cudart (or nvcc?) * remove the outdated cufile skip condition (it was buggy anyway) * remove 11.8 CI and add 13.0 CI * update cuda-bindings optional dependencies * update release notes * update cuda-bindings docs * update cuda-python docs * libnvvm is also split out * ensure using sanitizer from the latest release of the same major ver * Remove -cu12 suffixes and add nvidia-nvvm in cuda_pathfinder/pyproject.toml. Make related changes in .github/workflows * fix backport branch's ci name * restore nvidia_wheels_cu12 * remove tests * always test 12.9.x with the latest driver * ensure fetch_ctk works with 12.x * Fix Linux libnvvm site-packages search for CTK 13 CTK 12: site-packages/nvidia/cuda_nvcc/nvvm/lib64/libnvvm.so CTK 13: site-packages/nvidia/cu13/lib/libnvvm.so.4 * update docs * add PTX ISA 9.0 to utils * sync 13.0.0 docs * Fix Windows site-packages search for CTK 13 * Also add "nvidia-nvvm~=13.0" in cuda_bindings/pyproject.toml * Add _work_around_known_bugs() in load_dl_linux.py To resolve this issue: #792 (comment) * driver_cu_result_explanations.py, runtime_cuda_error_explanations.py refresh (no-op) * SUPPORTED_LINUX_SONAMES refresh (no-op) * SUPPORTED_WINDOWS_DLLS refresh (no-op) * Update generated files: nvjitlink, nvvm (trivial changes, functional no-op) * update release dates --------- Co-authored-by: Vladislav Zhurba <vzhurba@nvidia.com> Co-authored-by: Vladislav Zhurba <53052066+vzhurba01@users.noreply.github.com> Co-authored-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com> Co-authored-by: Ralf W. Grosse-Kunstleve <rwgkio@gmail.com> Co-authored-by: Robert Maynard <rmaynard@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes
Checklist