Use pyproject for auto discovery of packages and data#220
Merged
vzhurba01 merged 1 commit intoNVIDIA:mainfrom Nov 6, 2024
Merged
Use pyproject for auto discovery of packages and data#220vzhurba01 merged 1 commit intoNVIDIA:mainfrom
vzhurba01 merged 1 commit intoNVIDIA:mainfrom
Conversation
vzhurba01
added
bug
Contributor
leofang
approved these changes
Nov 6, 2024
Member
leofang
left a comment
leofang
left a comment
There was a problem hiding this comment.
Thanks, Vlad! So this fixes the Windows build, and has no effect on the Linux build (so that the hot fixes pushed out are fine)?
Contributor
Author
|
Correct. The hot fixes pushed out are fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adopts the same auto-discovery style as the cuda.core counterpart. This amendment is assured to expose the same data file as the posted Linux 12.6.2 patch. The change in style assist in getting most of the Windows files through.
Know issue: Windows builds can't auto-discover the trampoline files and they remain omitted from the final distributable. Note that Linux with this change does not face the same issue.