Skip to content

Use pyproject for auto discovery of packages and data#219

Merged
vzhurba01 merged 1 commit intoNVIDIA:11.8.xfrom
vzhurba01:patch-11.8.5-windows
Nov 6, 2024
Merged

Use pyproject for auto discovery of packages and data#219
vzhurba01 merged 1 commit intoNVIDIA:11.8.xfrom
vzhurba01:patch-11.8.5-windows

Conversation

@vzhurba01
Copy link
Contributor

This PR adopts the same auto-discovery style as the cuda.core counterpart. This amendment is assured to expose the same data file as the posted Linux 11.8.5 patch. The change in style assist in getting most of the Windows files through.

Know issue: Windows builds can't auto-discover the trampoline files and they remain omitted from the final distributable. Note that Linux with this change does not face the same issue.

@vzhurba01 vzhurba01 added bug Something isn't working P0 High priority - Must do! cuda.bindings Everything related to the cuda.bindings module labels Nov 6, 2024
@vzhurba01 vzhurba01 added this to the cuda-python 12.6.2 & 11.8.5 milestone Nov 6, 2024
@vzhurba01 vzhurba01 self-assigned this Nov 6, 2024
@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Nov 6, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@vzhurba01 vzhurba01 merged commit ccaf45f into NVIDIA:11.8.x Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cuda.bindings Everything related to the cuda.bindings module P0 High priority - Must do!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants