Skip to content

Prerelease NVML bindings#1284

Merged
mdboom merged 18 commits intoNVIDIA:mainfrom
mdboom:nvml
Dec 9, 2025
Merged

Prerelease NVML bindings#1284
mdboom merged 18 commits intoNVIDIA:mainfrom
mdboom:nvml

Conversation

@mdboom
Copy link
Contributor

@mdboom mdboom commented Nov 24, 2025

No description provided.

@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Nov 24, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@leofang leofang linked an issue Nov 24, 2025 that may be closed by this pull request
Add nvml bindings #863
Closed
1 task
@leofang leofang added P0 High priority - Must do! feature New feature or request cuda.bindings Everything related to the cuda.bindings module labels Nov 24, 2025
@mdboom
Copy link
Contributor Author

mdboom commented Nov 24, 2025

/ok to test

@github-actions

This comment has been minimized.

Sign in to view
@mdboom
Copy link
Contributor Author

mdboom commented Nov 24, 2025

/ok to test

rwgk
rwgk reviewed Nov 25, 2025
View reviewed changes
@rwgk rwgk mentioned this pull request Nov 26, 2025
Open
@mdboom
Copy link
Contributor Author

mdboom commented Dec 1, 2025

/ok to test

@mdboom
Copy link
Contributor Author

mdboom commented Dec 1, 2025

/ok to test

@mdboom
Copy link
Contributor Author

mdboom commented Dec 1, 2025

/ok to test

@mdboom
Copy link
Contributor Author

mdboom commented Dec 1, 2025

/ok to test

@leofang
Copy link
Member

leofang commented Dec 1, 2025

Let's get #1244 merged first to reduce the diff (from cufile).

@mdboom
Copy link
Contributor Author

mdboom commented Dec 2, 2025

Let's get #1244 merged first to reduce the diff (from cufile).

Yes, if we want to merge #1244 before 13.1 (I'm not sure that we do).

@mdboom
Copy link
Contributor Author

mdboom commented Dec 2, 2025

/ok to test

@mdboom
Copy link
Contributor Author

mdboom commented Dec 2, 2025

/ok to test

@mdboom
Copy link
Contributor Author

mdboom commented Dec 2, 2025

/ok to test

@mdboom
Copy link
Contributor Author

mdboom commented Dec 2, 2025

/ok to test

@mdboom mdboom marked this pull request as ready for review December 3, 2025 16:02
@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Dec 3, 2025

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

kkraus14
kkraus14 previously requested changes Dec 3, 2025
View reviewed changes
Copy link
Collaborator

@kkraus14 kkraus14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes purely to prevent merging shortly before release 😄

@mdboom
Copy link
Contributor Author

mdboom commented Dec 8, 2025

/ok to test

@kkraus14 kkraus14 dismissed their stale review December 8, 2025 16:20

Release is out :)

@mdboom
Copy link
Contributor Author

mdboom commented Dec 8, 2025

/ok to test

rwgk
rwgk reviewed Dec 8, 2025
View reviewed changes
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple basic things that stood out to me while glancing through.

kkraus14
kkraus14 approved these changes Dec 9, 2025
View reviewed changes
Copy link
Collaborator

@kkraus14 kkraus14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than @rwgk's comments 😄

@mdboom
Copy link
Contributor Author

mdboom commented Dec 9, 2025

/ok to test

@mdboom mdboom enabled auto-merge (squash) December 9, 2025 14:01
@mdboom mdboom merged commit df394be into NVIDIA:main Dec 9, 2025
80 checks passed
@github-actions
Copy link

github-actions bot commented Dec 9, 2025

Doc Preview CI
Preview removed because the pull request was closed or merged.

@mdboom mdboom deleted the nvml branch December 9, 2025 16:12
@leofang
Copy link
Member

leofang commented Jan 14, 2026

Backported in #1349.

@leofang leofang added this to the cuda-python 13.1.0 & 12.9.5 milestone Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rwgk rwgk rwgk left review comments

@leofang leofang leofang left review comments

@kkraus14 kkraus14 kkraus14 approved these changes

Assignees

@mdboom mdboom

Labels

cuda.bindings Everything related to the cuda.bindings module feature New feature or request P0 High priority - Must do!

Projects

None yet

Milestone

cuda-python 13.1.0 & 12.9.5

Development

Successfully merging this pull request may close these issues.

Add nvml bindings

4 participants

@mdboom @leofang @rwgk @kkraus14