Use new faster auto lowpp class implementation#1244
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
mdboom
force-pushed
the
fast-auto-lowpp-class2
branch
from
468f640 to
06930f5
Compare
mdboom
force-pushed
the
fast-auto-lowpp-class2
branch
from
06930f5 to
f01c309
Compare
|
/ok to test |
leofang
added
enhancement
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
I have confirmed with the tool in #1067 that there is no change in the ABI. Unfortunately, the changes in this PR are /not/ tested in CI, given this on all of the tests that use these types. We will need to perform some manual testing. |
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
mdboom
force-pushed
the
fast-auto-lowpp-class2
branch
from
5507171 to
104a5bb
Compare
|
/ok to test |
| return self._data.read_size_kb_hist | ||
| cdef view.array arr = view.array(shape=(32,), itemsize=sizeof(uint64_t), format="Q", mode="c", allocate_buffer=False) | ||
| arr.data = <char *>(&(self._ptr[0].read_size_kb_hist)) | ||
| return arr |
There was a problem hiding this comment.
Q: Can we wrap it as a numpy array here to avoid breaking?
| return self._data.write_size_kb_hist | ||
| cdef view.array arr = view.array(shape=(32,), itemsize=sizeof(uint64_t), format="Q", mode="c", allocate_buffer=False) | ||
| arr.data = <char *>(&(self._ptr[0].write_size_kb_hist)) | ||
| return arr |
|
/ok to test |
|
I have reverted the backward compatibility by returning numpy arrays, rather than Cython arrays, from members that have numeric array types. I tested this again on a machine that doesn't skip the There is still one breaking change here, noted in the release notes, that IMHO is just a real bug -- |
|
/ok to test |
|
4 participants
This is still somewhat a WIP, but I would like to get more CI.