Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

/ok to test 6563550

/ok to test

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

/ok to test

Check job still completes instead of spinning: https://github.com/NVIDIA/cuda-python/actions/runs/18165463144/job/51706593048?pr=1008

@leofang Can you paste the names of the checks here from the UI? I can't see them because I don't have access.

Once we are sure the check job completes the last, we can either adjust the repo setting and then merge, or admin-merge then adjust the repo setting. But we are not there yet. The repo setting is irrelevant of the failure of waiting for dependent jobs here. It is just a workflow bug that we should fix first.

/ok to test

I'm going to try one more alternative to avoid the action entirely.

I really don't like having to add an arbitrary delay to get this to work.

Yeah adding a random delay is flakey. It could proceed to complete when build jobs finish but the test jobs are still being spawned. Not a fan either.

/ok to test

/ok to test

The current Check job status / Check job status required check needs to be changed to CI / Check job status.

I applied it. You can see it now becomes "required". I haven't removed the old check yet.

But I am confused: If this is required, we still need to execute /ok to test, skip build/test/doc jobs, and make this job execute and turn green, right? But the current logic (mysteriously) also skips the status check job. Am I missing something?

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/about-status-checks

The new status check job should be considered passing, because it's skipped, according to that documentation.

I'm try to taking advantage of the fact that skip == success.

Figured it out: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/troubleshooting-required-status-checks#handling-skipped-but-required-checks

/ok to test

/ok to test

@leofang It looks like the push check is somehow different from the check that's waiting. Are push checks separate in the checks UI?

I am checking. This is odd because as discussed earlier once a CI job is run, it should appear as a registered job in the repo setting's dropdown menu, but for some reason I had to type the full name explicitly without anything popping out for me to choose.

This is what's in the ruleset that Keith set up. I added the last row manually. Nothing is "push"-specific 🤔

@cpcloud I think I fixed it. It's just "Check job status" (without "CI"), see the last row:

You can see your new job becomes required now. But, it does not seem to be allowing a green merge button? Is it because I still haven't removed the old check?

Is it because I still haven't removed the old check?

Yep, that has to be removed before merge is allowed.

Let me check quickly. btw we'll need to backport this PR to 12.9.x. Keith applied the same ruleset to all branches.

It works now! To avoid race condition I am merging immediately.

Thanks for the review, much appreciated!

Thanks for working this out Phillip!