Hardcode DeviceTransform offset type to I64 or U64#9040
Draft
bernhardmgruber wants to merge 2 commits into
Draft
Hardcode DeviceTransform offset type to I64 or U64#9040bernhardmgruber wants to merge 2 commits into
DeviceTransform offset type to I64 or U64#9040bernhardmgruber wants to merge 2 commits into
Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
bernhardmgruber
changed the title
DeviceTransform offset type to I64DeviceTransform offset type to I64 or U64
Contributor
|
Should this go into 3.4? |
miscco
approved these changes
May 17, 2026
Comment on lines
+559
to
+561
| // static_assert( | ||
| // ::cuda::std::is_same_v<Offset, ::cuda::std::int32_t> || ::cuda::std::is_same_v<Offset, ::cuda::std::int64_t>, | ||
| // "cub::DeviceTransform is only tested and tuned for 32-bit or 64-bit signed offset types"); |
Contributor
There was a problem hiding this comment.
Shouldnt this still be checking that we only use int64?
Contributor
Author
There was a problem hiding this comment.
It will eventually just go away, since I want to replace the template parameter Offset by just the hardcoded 64-bit type that wins the race. I still need data for Blackwell and probably Ampere.
Contributor
Author
It's fine to ship later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8805