Skip to content

Conversation

@VALLIS-NERIA
Copy link
Collaborator

@VALLIS-NERIA VALLIS-NERIA commented Dec 5, 2025

Summary by CodeRabbit

  • Refactor

    • Improved CUDA architecture compatibility targeting newer compute capabilities.
    • Enhanced driver compatibility handling for improved system support.
    • Cleaned up unused code and optimized internal structure.
  • Chores

    • Reorganized build configuration for better compilation consistency.

✏️ Tip: You can customize this high-level summary in your review settings.

Description

cherry pick of #8167

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Signed-off-by: Xiwen Yu <13230610+VALLIS-NERIA@users.noreply.github.com>
@VALLIS-NERIA VALLIS-NERIA self-assigned this Dec 5, 2025
@VALLIS-NERIA VALLIS-NERIA requested a review from a team as a code owner December 5, 2025 09:34
@VALLIS-NERIA VALLIS-NERIA added the Release Blocker PRs that blocking the final release build or branching out the release branch label Dec 5, 2025
@VALLIS-NERIA VALLIS-NERIA changed the title [https://nvbugs/5503138] [fix] Remove compile warnings (#8167) [https://nvbugs/5503138] [fix] Remove compile warnings Dec 5, 2025
@VALLIS-NERIA
Copy link
Collaborator Author

/bot run

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 5, 2025

📝 Walkthrough

Walkthrough

Four kernel source files receive targeted modifications: architecture-specific compilation guards for newer GPU support, simplification of conditional compilation for driver API calls, removal of unused pointer initializations, and include file reorganization. No public interfaces or exported signatures are altered.

Changes

Cohort / File(s) Summary
Compilation Optimization
cpp/tensorrt_llm/kernels/communicationKernels/mnnvlTwoShotAllreduceKernels.cu, cpp/tensorrt_llm/kernels/cutlass_kernels/fp8_blockscale_gemm/fp8_blockscale_tma_utils.cuh
Conditional compilation modifications: first file wraps block_reduce_sum and loadfloat4 helper behind CUDA architecture >= 900 guard; second file replaces conditional path selection with single call to cudaGetDriverEntryPointByVersion (version 12000).
Kernel Cleanup
cpp/tensorrt_llm/kernels/recoverFromRingAtten.cu
Adds diagnostic pragma support block preceding shared barrier declaration; removes unused local pointer initializations (accu_softmax_sum, accu_softmax_max, softmax_sum, softmax_max) from invokeRecoverFromRA function.
Build Organization
cpp/tensorrt_llm/kernels/trtllmGenKernels/gemm/KernelRunner.cpp
Reorders include directives; moves GemmInterface.h, GemmOptions.h, and DtypeDecl.h before KernelRunner.h with clang-format control comments.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • fp8_blockscale_tma_utils.cuh — Driver API version simplification requires verification that cudaGetDriverEntryPointByVersion (12000) is compatible across target environments
  • recoverFromRingAtten.cu — Verify that removed pointer initializations have no indirect effects on kernel behavior or subsequent state management

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Description check ❓ Inconclusive The PR description only states 'cherry pick of #8167' without explaining what the cherry-pick contains, why it's needed, or what problems it solves. Add a meaningful description of the changes being cherry-picked, including what compile warnings are being fixed and why they matter for the release branch.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly follows the template format and accurately describes the primary change: removing compile warnings across multiple CUDA kernel files.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #27104 [ run ] triggered by Bot. Commit: 2c19699

@VALLIS-NERIA VALLIS-NERIA enabled auto-merge (squash) December 5, 2025 10:25
@tensorrt-cicd
Copy link
Collaborator

PR_Github #27104 [ run ] completed with state SUCCESS. Commit: 2c19699
/LLM/release-1.1/L0_MergeRequest_PR pipeline #558 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@VALLIS-NERIA VALLIS-NERIA merged commit 9a421d0 into NVIDIA:release/1.1 Dec 5, 2025
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Release Blocker PRs that blocking the final release build or branching out the release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants