[TRTLLM-9082][doc] Address Dynamo Example feedback #9619

Tabrizian · 2025-12-02T08:13:31Z

Summary by CodeRabbit

Documentation
- Simplified Kubernetes deployment documentation for TensorRT-LLM on Dynamo Cloud with streamlined instructions and direct references to the Kubernetes Quick Start Guide for additional guidance.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Signed-off-by: Iman Tabrizian <10105175+tabrizian@users.noreply.github.com>

coderabbitai · 2025-12-02T08:16:35Z

📝 Walkthrough

Walkthrough

Documentation file updated to replace a two-step instructional section with a concise paragraph describing TensorRT-LLM deployment on Kubernetes via Dynamo Cloud, including references to operator-based lifecycle management through CRDs and a link to the Kubernetes Quick Start Guide.

Changes

Cohort / File(s)	Summary
Documentation simplification `docs/source/examples/dynamo_k8s_example.rst`	Consolidated multi-step deployment instructions into a single paragraph; removed details about Dynamo Cloud installation and TRT-LLM deployment steps; retained CRD-based lifecycle management references and added pointer to Kubernetes Quick Start Guide

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Accuracy verification: Confirm that the consolidated paragraph accurately represents the original instructional content and doesn't omit critical deployment steps
Link validity: Verify that the Kubernetes Quick Start Guide reference is current and accessible

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	PR description is incomplete; required sections for Description and Test Coverage are empty or missing substantive content explaining the changes.	Fill in the Description section explaining what was changed and why, and provide Test Coverage details for the documentation updates to the Dynamo Kubernetes example file.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title follows the required format [JIRA-ticket][type] and is directly related to the main change: addressing feedback on the Dynamo example documentation.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

docs/source/examples/dynamo_k8s_example.rst (1)

4-7: Consider whether the documentation serves the intended purpose of an "example" file.

The change has simplified the documentation from a multi-step walkthrough to a single conceptual paragraph with an external link. For a file titled "Dynamo K8s Example," users might expect more concrete guidance or deployment steps.

If this simplified approach is the intended resolution to the feedback mentioned in the PR objective (addressing Dynamo Example feedback), consider whether the title and structure align with the new content. An alternative title such as "Dynamo Kubernetes Deployment" might better reflect that this is a conceptual overview rather than a step-by-step example.

If you'd like to retain step-by-step guidance while maintaining conciseness, would you prefer to keep the original instructions and refine them, or is the current approach the desired outcome from the feedback?

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6f7804f and 9b4dd4c.

📒 Files selected for processing (1)

docs/source/examples/dynamo_k8s_example.rst (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

📓 Common learnings

Learnt from: venkywonka
Repo: NVIDIA/TensorRT-LLM PR: 6029
File: .github/pull_request_template.md:45-53
Timestamp: 2025-08-27T17:50:13.264Z
Learning: For PR templates in TensorRT-LLM, avoid suggesting changes that would increase developer overhead, such as converting plain bullets to mandatory checkboxes. The team prefers guidance-style bullets that don't require explicit interaction to reduce friction in the PR creation process.

Learnt from: farshadghodsian
Repo: NVIDIA/TensorRT-LLM PR: 7101
File: docs/source/blogs/tech_blog/blog9_Deploying_GPT_OSS_on_TRTLLM.md:36-36
Timestamp: 2025-08-21T00:16:56.457Z
Learning: TensorRT-LLM container release tags in documentation should only reference published NGC container images. The README badge version may be ahead of the actual published container versions.

Learnt from: achartier
Repo: NVIDIA/TensorRT-LLM PR: 6763
File: tests/integration/defs/triton_server/conftest.py:16-22
Timestamp: 2025-08-11T20:09:24.389Z
Learning: In the TensorRT-LLM test infrastructure, the team prefers simple, direct solutions (like hard-coding directory traversal counts) over more complex but robust approaches when dealing with stable directory structures. They accept the maintenance cost of updating tests if the layout changes.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Pre-commit Check

🔇 Additional comments (1)

docs/source/examples/dynamo_k8s_example.rst (1)

4-7: The external link to NVIDIA's Dynamo Kubernetes documentation is valid and published. The RST syntax for the external link is correct.

QiJune

LGTM

QiJune · 2025-12-02T08:42:12Z

/bot run

tensorrt-cicd · 2025-12-02T08:48:46Z

PR_Github #26575 [ run ] triggered by Bot. Commit: 9b4dd4c

tensorrt-cicd · 2025-12-02T09:25:53Z

PR_Github #26575 [ run ] completed with state SUCCESS. Commit: 9b4dd4c
/LLM/release-1.1/L0_MergeRequest_PR pipeline #552 completed with status: 'SUCCESS'

Signed-off-by: Iman Tabrizian <10105175+tabrizian@users.noreply.github.com>

Signed-off-by: Iman Tabrizian <10105175+tabrizian@users.noreply.github.com> Signed-off-by: Mike Iovine <6158008+mikeiovine@users.noreply.github.com>

Signed-off-by: Iman Tabrizian <10105175+tabrizian@users.noreply.github.com> Signed-off-by: Mike Iovine <6158008+mikeiovine@users.noreply.github.com> Signed-off-by: Mike Iovine <miovine@nvidia.com>

[TRTLLM-9082][doc] Address Dynamo Example feedback

9b4dd4c

Signed-off-by: Iman Tabrizian <10105175+tabrizian@users.noreply.github.com>

Tabrizian requested a review from a team as a code owner December 2, 2025 08:13

Tabrizian requested a review from QiJune December 2, 2025 08:13

coderabbitai bot reviewed Dec 2, 2025

View reviewed changes

QiJune approved these changes Dec 2, 2025

View reviewed changes

chzblych approved these changes Dec 2, 2025

View reviewed changes

chzblych enabled auto-merge (squash) December 2, 2025 08:50

chzblych merged commit ac5aa63 into NVIDIA:release/1.1 Dec 2, 2025
7 of 9 checks passed

mikeiovine pushed a commit to mikeiovine/TensorRT-LLM that referenced this pull request Dec 12, 2025

[TRTLLM-9082][doc] Address Dynamo Example feedback (NVIDIA#9619)

2bea986

Signed-off-by: Iman Tabrizian <10105175+tabrizian@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[TRTLLM-9082][doc] Address Dynamo Example feedback #9619

[TRTLLM-9082][doc] Address Dynamo Example feedback #9619

Uh oh!

Tabrizian commented Dec 2, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Dec 2, 2025 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Uh oh!

coderabbitai bot left a comment

Uh oh!

QiJune left a comment

Uh oh!

QiJune commented Dec 2, 2025

Uh oh!

tensorrt-cicd commented Dec 2, 2025

Uh oh!

tensorrt-cicd commented Dec 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[TRTLLM-9082][doc] Address Dynamo Example feedback #9619

[TRTLLM-9082][doc] Address Dynamo Example feedback #9619

Uh oh!

Conversation

Tabrizian commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Description

Test Coverage

PR Checklist

GitHub Bot Help

kill

skip

reuse-pipeline

Uh oh!

coderabbitai bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Pre-merge checks and finishing touches

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

QiJune left a comment

Choose a reason for hiding this comment

Uh oh!

QiJune commented Dec 2, 2025

Uh oh!

tensorrt-cicd commented Dec 2, 2025

Uh oh!

tensorrt-cicd commented Dec 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Tabrizian commented Dec 2, 2025 •

edited

Loading

coderabbitai bot commented Dec 2, 2025 •

edited

Loading