[TRTINFRA-7280][infra] Support enroot/pyxis clusters in multi-node SLURM and enable oci-hsg GB200 in post-merge #9117
Conversation
|
/bot run --disable-fail-fast |
Signed-off-by: Matt Lefebvre <mlefebvre@nvidia.com>
mlefeb01
force-pushed
the
slurm-enroot-multinode
branch
from
71541e4 to
e9d5ad8
Compare
📝 WalkthroughWalkthroughIntroduces ENROOT-specific handling in the SLURM container execution path: when cluster.containerRuntime == ENROOT, extends mounts to include the job workspace, derives a container image argument from SLURM_JOB_ID, and injects a prologue with ENROOT_CACHE_PATH, a retry_command helper, and an initial enroot import. Non-ENROOT runtimes unchanged. Changes
Sequence DiagramsequenceDiagram
participant Generator as SLURM Script Generator
participant Prologue as ENROOT Prologue
participant Retry as retry_command
participant Enroot as enroot
Generator->>Generator: Check containerRuntime == ENROOT
alt ENROOT
Generator->>Generator: Add workspace to mounts
Generator->>Generator: Derive containerImageArg from SLURM_JOB_ID
Generator->>Prologue: Inject srunPrologue before srun
Prologue->>Prologue: Export ENROOT_CACHE_PATH
Prologue->>Retry: Run enroot import via retry_command
Retry->>Enroot: Attempt enroot import
alt success
Enroot-->>Retry: Success
else fail/retry
Retry->>Retry: Sleep and retry
Retry->>Enroot: Retry import
end
Prologue-->>Generator: Prologue ready
Generator->>Generator: Invoke srun with containerImageArg
else Non-ENROOT
Generator->>Generator: Use existing srun configuration
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
PR_Github #24376 [ run ] triggered by Bot. Commit: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
jenkins/L0_Test.groovy (1)
962-963: Consider adding explicit error checking after enroot import.While the retry mechanism will catch transient failures, consider adding explicit validation that the image was created successfully before proceeding with srun.
Add image validation after the import:
retry_command "enroot import -o $enrootImagePath -- docker://$container" + +if [ ! -f "$enrootImagePath" ]; then + echo "ERROR: ENROOT image not found at $enrootImagePath after import" + exit 1 +fi + +echo "ENROOT image successfully created at $enrootImagePath" """.replaceAll("(?m)^\\s*", "")
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
jenkins/L0_Test.groovy(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (2)
jenkins/L0_Test.groovy (2)
995-996: LGTM - Prologue injection is correctly placed.The
srunPrologueis injected at the appropriate location in the bash script, after environment variable exports and before thesruncommand. This ensures that ENROOT-specific setup (cache path, retry helper, and image import) completes before the containerized workload starts.
933-933: The workspace mount syntax is correct for ENROOT.ENROOT supports single-path mount syntax as a shorthand to mount the same host path at the same location inside the container. The
"${jobWorkspace}"mount at line 933 is valid and intentional (as noted by the comment on line 932). Other mounts use thesource:destination:optionsformat because they require path remapping or read-only flags, whereas the workspace needs to be accessible at its original path inside the container.
|
/bot run --disable-fail-fast |
|
PR_Github #24379 [ run ] triggered by Bot. Commit: |
|
PR_Github #24376 [ run ] completed with state |
|
PR_Github #24379 [ run ] completed with state |
|
/bot run --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-1" |
|
PR_Github #24494 [ run ] triggered by Bot. Commit: |
|
PR_Github #24494 [ run ] completed with state |
Signed-off-by: Matt Lefebvre <mlefebvre@nvidia.com>
mlefeb01
changed the title
|
/bot run --stage-list "GB200-4_GPUs-PyTorch-Post-Merge-1,GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-1,GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-2,GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-3" |
|
PR_Github #24498 Bot args parsing error: Traceback (most recent call last): During handling of the above exception, another exception occurred: Traceback (most recent call last): |
|
/bot run --stage-list "GB200-4_GPUs-PyTorch-Post-Merge-1,GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-1,GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-2,GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-3" |
|
PR_Github #24500 [ run ] triggered by Bot. Commit: |
|
PR_Github #24501 [ run ] triggered by Bot. Commit: |
|
PR_Github #24500 [ run ] completed with state |
Signed-off-by: Matt Lefebvre <mlefebvre@nvidia.com>
|
/bot run --stage-list "GB200-4_GPUs-PyTorch-Post-Merge-1,GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-1,GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-2,GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-3" |
|
PR_Github #24508 [ run ] triggered by Bot. Commit: |
|
/bot run --stage-list "GB200-4_GPUs-PyTorch-Post-Merge-1,GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-1,GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-2,GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-3" |
|
PR_Github #24618 [ run ] triggered by Bot. Commit: |
|
PR_Github #24618 [ run ] completed with state |
|
/bot run --stage-list "GB200-4_GPUs-PyTorch-Post-Merge-1,GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-1,GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-2,GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-3" --disable-fail-fast |
|
PR_Github #24625 [ run ] triggered by Bot. Commit: |
|
PR_Github #24626 [ run ] triggered by Bot. Commit: |
|
PR_Github #24625 [ run ] completed with state |
|
PR_Github #24626 [ run ] completed with state |
|
/bot run --stage-list "GB200-4_GPUs-PyTorch-Post-Merge-1,GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-1,GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-2,GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-3" --disable-fail-fast |
|
PR_Github #24659 [ run ] triggered by Bot. Commit: |
|
PR_Github #24659 [ run ] completed with state |
|
/bot run --stage-list "GB200-4_GPUs-PyTorch-Post-Merge-1,GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-1,GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-2,GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-3" --disable-fail-fast |
|
PR_Github #24689 [ run ] triggered by Bot. Commit: |
|
PR_Github #24689 [ run ] completed with state |
|
/bot run --stage-list "GB200-4_GPUs-PyTorch-Post-Merge-1,GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-1,GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-2,GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-3" --disable-fail-fast |
|
PR_Github #24692 [ run ] triggered by Bot. Commit: |
|
PR_Github #24692 [ run ] completed with state |
|
/bot skip --comment "" |
|
PR_Github #24792 [ skip ] triggered by Bot. Commit: |
|
PR_Github #24792 [ skip ] completed with state |
4 participants
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
Details
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.