[https://nvbugs/5461796][fix] Unwaive and extend time for test_llmapi_speculative_decoding_mtp #9092

sunnyqgg · 2025-11-12T09:08:02Z

Summary by CodeRabbit

Style
- Code formatting adjustments in examples for improved consistency.
Tests
- Removed previously waived test entry to enhance test reliability.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

coderabbitai · 2025-11-12T09:10:01Z

📝 Walkthrough

Walkthrough

The pull request removes a blank line from a Python example file and deletes a test waiver entry. Both changes are formatting and administrative adjustments with no behavioral impact.

Changes

Cohort / File(s)	Change Summary
Code formatting `examples/llm-api/llm_speculative_decoding.py`	Removed a blank line between LLM initialization and for loop in the `run_MTP` function
Test waiver management `tests/integration/test_lists/waives.txt`	Deleted test waiver entry for `llmapi/test_llm_examples.py::test_llmapi_speculative_decoding_mtp`

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description is entirely a template with no actual content. Required sections (Description, Test Coverage) are empty, only a checkbox is marked.	Fill in the Description section explaining what the fix addresses (NVBugs 5461796), explain why the test waiver is being removed, and add relevant Test Coverage details.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title directly relates to the changeset: it removes a waiver entry for test_llmapi_speculative_decoding_mtp, which is exactly what the code changes accomplish.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

sunnyqgg · 2025-11-12T09:12:14Z

/bot run --debug --stage-list "{NGC-Release-Image-arm64-Sanity-Test-GH200}"

sunnyqgg · 2025-11-12T09:16:49Z

/bot run --debug --stage-list "NGC-Release-Image-arm64-Sanity-Test-GH200"

tensorrt-cicd · 2025-11-12T09:18:38Z

PR_Github #24287 [ run ] triggered by Bot. Commit: d334599

tensorrt-cicd · 2025-11-12T09:22:25Z

PR_Github #24288 [ run ] triggered by Bot. Commit: d334599

tensorrt-cicd · 2025-11-12T09:22:28Z

PR_Github #24287 [ run ] completed with state ABORTED. Commit: d334599

tensorrt-cicd · 2025-11-12T09:53:45Z

PR_Github #24288 [ run ] completed with state FAILURE. Commit: d334599
/LLM/release-1.1/L0_MergeRequest_PR pipeline #474 (Partly Tested) completed with status: 'FAILURE'

sunnyqgg · 2025-11-13T02:17:49Z

/bot run --debug --stage-list "Build-Docker-Images"

tensorrt-cicd · 2025-11-13T02:24:12Z

PR_Github #24364 [ run ] triggered by Bot. Commit: d334599

tensorrt-cicd · 2025-11-13T09:41:21Z

PR_Github #24364 [ run ] completed with state SUCCESS. Commit: d334599
/LLM/release-1.1/L0_MergeRequest_PR pipeline #476 (Partly Tested) completed with status: 'SUCCESS'

Signed-off-by: qgai <qgai@nvidia.com>

sunnyqgg · 2025-11-18T06:18:43Z

/bot run

tensorrt-cicd · 2025-11-18T06:24:34Z

PR_Github #24854 [ run ] triggered by Bot. Commit: d28b305

tensorrt-cicd · 2025-11-18T09:44:06Z

PR_Github #24854 [ run ] completed with state SUCCESS. Commit: d28b305
/LLM/release-1.1/L0_MergeRequest_PR pipeline #503 completed with status: 'SUCCESS'

…_speculative_decoding_mtp (NVIDIA#9092) Signed-off-by: qgai <qgai@nvidia.com>

…_speculative_decoding_mtp (NVIDIA#9092) Signed-off-by: qgai <qgai@nvidia.com> Signed-off-by: Mike Iovine <6158008+mikeiovine@users.noreply.github.com>

…_speculative_decoding_mtp (NVIDIA#9092) Signed-off-by: qgai <qgai@nvidia.com> Signed-off-by: Mike Iovine <6158008+mikeiovine@users.noreply.github.com> Signed-off-by: Mike Iovine <miovine@nvidia.com>

…_speculative_decoding_mtp (NVIDIA#9092) Signed-off-by: qgai <qgai@nvidia.com> Signed-off-by: Mike Iovine <6158008+mikeiovine@users.noreply.github.com> Signed-off-by: Mike Iovine <miovine@nvidia.com> Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>

sunnyqgg requested a review from a team as a code owner November 12, 2025 09:08

sunnyqgg added 2 commits November 18, 2025 06:05

try to reproduce /nvbug/5461796_v2

9188830

Signed-off-by: qgai <qgai@nvidia.com>

unwaive and extended time for test_llmapi_speculative_decoding_mtp

f49c1b2

Signed-off-by: qgai <qgai@nvidia.com>

sunnyqgg force-pushed the qgai/nvbug/5461796 branch from d334599 to f49c1b2 Compare November 18, 2025 06:12

remove blank

d28b305

Signed-off-by: qgai <qgai@nvidia.com>

sunnyqgg changed the title ~~[https://nvbugs/5461796][fix] Try to reproduce~~ [https://nvbugs/5461796][fix] Unwaive and extend time for test_llmapi_speculative_decoding_mtp Nov 18, 2025

sunnyqgg requested a review from EmmaQiaoCh November 18, 2025 10:24

kaiyux approved these changes Nov 18, 2025

View reviewed changes

kaiyux merged commit 35b176a into NVIDIA:release/1.1 Nov 18, 2025
7 checks passed

mikeiovine pushed a commit to mikeiovine/TensorRT-LLM that referenced this pull request Nov 20, 2025

[https://nvbugs/5461796][fix] Unwaive and extend time for test_llmapi…

eeace97

…_speculative_decoding_mtp (NVIDIA#9092) Signed-off-by: qgai <qgai@nvidia.com>

mikeiovine pushed a commit to mikeiovine/TensorRT-LLM that referenced this pull request Nov 20, 2025

[https://nvbugs/5461796][fix] Unwaive and extend time for test_llmapi…

10e8aba

…_speculative_decoding_mtp (NVIDIA#9092) Signed-off-by: qgai <qgai@nvidia.com>

[https://nvbugs/5461796][fix] Unwaive and extend time for test_llmapi_speculative_decoding_mtp #9092

[https://nvbugs/5461796][fix] Unwaive and extend time for test_llmapi_speculative_decoding_mtp #9092

Uh oh!

Conversation

sunnyqgg commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Description

Test Coverage

PR Checklist

GitHub Bot Help

kill

skip

reuse-pipeline

Uh oh!

coderabbitai bot commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Pre-merge checks and finishing touches

Uh oh!

sunnyqgg commented Nov 12, 2025

Uh oh!

sunnyqgg commented Nov 12, 2025

Uh oh!

tensorrt-cicd commented Nov 12, 2025

Uh oh!

tensorrt-cicd commented Nov 12, 2025

Uh oh!

tensorrt-cicd commented Nov 12, 2025

Uh oh!

tensorrt-cicd commented Nov 12, 2025

Uh oh!

sunnyqgg commented Nov 13, 2025

Uh oh!

tensorrt-cicd commented Nov 13, 2025

Uh oh!

tensorrt-cicd commented Nov 13, 2025

Uh oh!

sunnyqgg commented Nov 18, 2025

Uh oh!

tensorrt-cicd commented Nov 18, 2025

Uh oh!

tensorrt-cicd commented Nov 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sunnyqgg commented Nov 12, 2025 •

edited

Loading

coderabbitai bot commented Nov 12, 2025 •

edited

Loading