[TRTLLM-9247][infra] Upgrade NIXL to 0.7.1 #9055
Conversation
📝 WalkthroughWalkthroughVersion numbers for two dependencies in Docker installation scripts were updated. NIXL version incremented from 0.5.0 to 0.7.1, and UCX version incremented from v1.19.x to v1.20.x. No logic or control-flow changes observed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
docker/common/install_nixl.sh(1 hunks)docker/common/install_ucx.sh(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (1)
docker/common/install_ucx.sh (1)
4-4: I need to verify the UCX version availability and compatibility more thoroughly. Let me search for additional information.Let me search for more information about UCX 1.20 releases and NIXL 0.7.1 compatibility.
Resolve: UCX v1.20.x does not exist as a released version; NIXL 0.7.1 does not exist.
UCX v1.20.0 is only scheduled for release (spec file dated April 11, 2025) and no official v1.20.x release tag currently exists in the repository. NIXL was tested with UCX version 1.19.0, and the latest available NIXL release is 0.5.1—NIXL 0.7.1 does not exist. Using the unreleased v1.20.x version string is incorrect and unsupported. Change to
UCX_VERSION="v1.19.0"to match current NIXL compatibility, or verify if you intend to use an actual release tag.Likely an incorrect or invalid review comment.
bo-nv
force-pushed
the
user/bo/nixl-0.7.1
branch
from
3d8ede7 to
9cb3a67
Compare
|
/bot run --stage-list "Build-Docker-Images" |
1 similar comment
|
/bot run --stage-list "Build-Docker-Images" |
|
PR_Github #24204 [ run ] triggered by Bot. Commit: |
|
PR_Github #24204 [ run ] completed with state |
|
/bot run |
|
PR_Github #24238 [ run ] triggered by Bot. Commit: |
|
PR_Github #24238 [ run ] completed with state |
|
/bot run |
|
PR_Github #24250 [ run ] triggered by Bot. Commit: |
|
PR_Github #24250 [ run ] completed with state |
bo-nv
force-pushed
the
user/bo/nixl-0.7.1
branch
from
dbe8fe4 to
6a36aab
Compare
|
/bot run |
1 similar comment
|
/bot run |
|
PR_Github #24344 [ run ] triggered by Bot. Commit: |
|
PR_Github #24344 [ run ] completed with state |
|
/bot run --disable-fail-fast |
|
PR_Github #24393 [ run ] triggered by Bot. Commit: |
|
/bot run --add-multi-gpu-test --disable-fail-fast |
|
PR_Github #25071 [ run ] triggered by Bot. Commit: |
|
PR_Github #25055 [ run ] completed with state |
|
/bot run --add-multi-gpu-test --disable-fail-fast |
|
PR_Github #25085 [ run ] triggered by Bot. Commit: |
|
PR_Github #25071 [ run ] completed with state |
|
/bot run --add-multi-gpu-test --disable-fail-fast |
|
PR_Github #25085 [ run ] completed with state |
|
/bot run --add-multi-gpu-test --disable-fail-fast |
|
PR_Github #25091 [ run ] triggered by Bot. Commit: |
|
PR_Github #25092 [ run ] triggered by Bot. Commit: |
|
PR_Github #25091 [ run ] completed with state |
|
PR_Github #25092 [ run ] completed with state |
Signed-off-by: Bo Deng <deemod@nvidia.com>
|
/bot skip --comment "Just re-tag images,https://prod.blsm.nvidia.com/sw-tensorrt-top-1/job/LLM/job/main/job/L0_MergeRequest_PR/18968/“ |
|
PR_Github #25114 Bot args parsing error: Traceback (most recent call last): During handling of the above exception, another exception occurred: Traceback (most recent call last): |
|
/bot skip --comment "Just re-tag images,https://prod.blsm.nvidia.com/sw-tensorrt-top-1/job/LLM/job/main/job/L0_MergeRequest_PR/18968/) |
|
PR_Github #25115 Bot args parsing error: Traceback (most recent call last): During handling of the above exception, another exception occurred: Traceback (most recent call last): |
|
/bot skip --comment "Just re-tag images,https://prod.blsm.nvidia.com/sw-tensorrt-top-1/job/LLM/job/main/job/L0_MergeRequest_PR/18968/)“ |
|
PR_Github #25118 Bot args parsing error: Traceback (most recent call last): During handling of the above exception, another exception occurred: Traceback (most recent call last): |
|
/bot skip --comment "Just re-tag images,https://prod.blsm.nvidia.com/sw-tensorrt-top-1/job/LLM/job/main/job/L0_MergeRequest_PR/18968/) " |
|
PR_Github #25119 [ skip ] triggered by Bot. Commit: |
Signed-off-by: Bo Deng <deemod@nvidia.com>
|
/bot skip --comment "Just re-tag images,https://prod.blsm.nvidia.com/sw-tensorrt-top-1/job/LLM/job/main/job/L0_MergeRequest_PR/18968/) " |
|
PR_Github #25119 [ skip ] completed with state |
|
PR_Github #25123 [ skip ] triggered by Bot. Commit: |
|
PR_Github #25123 [ skip ] completed with state |
8 participants
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
Details
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.