[None][fix] Fix the aux_stream in Llama4MinLatencyFusedMoE #9035
Conversation
jinyangyuan-nvidia
force-pushed
the
dev/fix_llama_moe_aux_stream
branch
from
9ae4b49 to
bdd6539
Compare
jinyangyuan-nvidia
changed the title
📝 WalkthroughWalkthroughThe changes replace a single auxiliary stream parameter with a dictionary-based configuration in two Llama model classes. Parameter type shifts from Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant LlamaClass as Llama4MinLatency{Linear/FusedMoE}
participant BaseClass
Note over Caller,LlamaClass `#DDDDFF`: New call site supplies aux_stream_dict
Caller->>LlamaClass: __init__(..., aux_stream_dict=Dict[AuxStreamType, Stream])
LlamaClass->>BaseClass: super().__init__(..., aux_stream_dict=aux_stream_dict)
BaseClass-->>LlamaClass: initialized with labeled auxiliary streams
LlamaClass-->>Caller: instance ready
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5–10 minutes
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@jinyangyuan-nvidia Thanks a lot for the quick fix! |
jinyangyuan-nvidia
force-pushed
the
dev/fix_llama_moe_aux_stream
branch
from
bdd6539 to
9c37e06
Compare
|
The original code does not pass |
|
/bot run |
|
PR_Github #23980 [ run ] triggered by Bot. Commit: |
|
PR_Github #23980 [ run ] completed with state |
|
/bot run |
|
PR_Github #24014 [ run ] triggered by Bot. Commit: |
|
PR_Github #24014 [ run ] completed with state |
|
/bot run |
|
PR_Github #24063 [ run ] triggered by Bot. Commit: |
|
PR_Github #24063 [ run ] completed with state |
|
/bot run |
|
PR_Github #24084 [ run ] triggered by Bot. Commit: |
|
PR_Github #24084 [ run ] completed with state |
jinyangyuan-nvidia
force-pushed
the
dev/fix_llama_moe_aux_stream
branch
from
9c37e06 to
78ac556
Compare
|
/bot run |
|
PR_Github #24114 [ run ] triggered by Bot. Commit: |
|
PR_Github #24114 [ run ] completed with state |
jinyangyuan-nvidia
force-pushed
the
dev/fix_llama_moe_aux_stream
branch
from
78ac556 to
b16d9c9
Compare
|
/bot run |
|
PR_Github #24186 [ run ] triggered by Bot. Commit: |
|
PR_Github #24186 [ run ] completed with state |
jinyangyuan-nvidia
force-pushed
the
dev/fix_llama_moe_aux_stream
branch
from
b16d9c9 to
fdb922e
Compare
|
/bot run |
|
PR_Github #24225 [ run ] triggered by Bot. Commit: |
|
PR_Github #24225 [ run ] completed with state |
|
/bot run |
|
PR_Github #24244 [ run ] triggered by Bot. Commit: |
|
PR_Github #24244 [ run ] completed with state |
Signed-off-by: Jinyang Yuan <154768711+jinyangyuan-nvidia@users.noreply.github.com>
kaiyux
force-pushed
the
dev/fix_llama_moe_aux_stream
branch
from
fdb922e to
efe2c03
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #24420 [ run ] triggered by Bot. Commit: |
|
PR_Github #24420 [ run ] completed with state |
Signed-off-by: Jinyang Yuan <154768711+jinyangyuan-nvidia@users.noreply.github.com>
Signed-off-by: Jinyang Yuan <154768711+jinyangyuan-nvidia@users.noreply.github.com>
5 participants
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
Details
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.