[None][infra] Waive failed tests for release branch 11/07 #9026

EmmaQiaoCh · 2025-11-09T03:54:12Z

Summary by CodeRabbit

Tests
- Updated test configuration for host function binding tests.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Signed-off-by: qqiao <qqiao@nvidia.com>

EmmaQiaoCh · 2025-11-09T03:54:39Z

/bot run --stage-list "GH200-TensorRT-Post-Merge-1"

coderabbitai · 2025-11-09T03:56:46Z

📝 Walkthrough

Walkthrough

Added pytest import and skip marker to test_hostfunc test function in the hostfunc test file, causing the test to be skipped unconditionally due to an external bug reference.

Changes

Cohort / File(s)	Change Summary
Test configuration `tests/unittest/bindings/test_hostfunc.py`	Added pytest import and unconditional skip marker to test_hostfunc test function due to external bug reference

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

yiqingy0
chzblych

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description is completely empty except for the template structure, with no actual content in the Description or Test Coverage sections and only the checkbox marked but no explanations provided.	Fill in the Description section explaining why tests are being waived and the Test Coverage section documenting which tests are affected and why they should be skipped.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title '[None][infra] Waive failed tests for release branch 11/07' clearly describes the main change: skipping/waiving failed tests for an infrastructure/release purpose on the specified date.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between def2ad5 and b986e4f.

📒 Files selected for processing (1)

tests/unittest/bindings/test_hostfunc.py (1 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

**/*.{h,hpp,hh,hxx,cpp,cxx,cc,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Use only spaces, no tabs; indent with 4 spaces.

Files:

tests/unittest/bindings/test_hostfunc.py

**/*.py

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

**/*.py: Python code must target Python 3.8+.
Indent Python code with 4 spaces; do not use tabs.
Maintain module namespace when importing; prefer 'from package.subpackage import foo' then 'foo.SomeClass()' instead of importing the class directly.
Python filenames should be snake_case (e.g., some_file.py).
Python classes use PascalCase names.
Functions and methods use snake_case names.
Local variables use snake_case; prefix 'k' for variables that start with a number (e.g., k_99th_percentile).
Global variables use upper SNAKE_CASE prefixed with 'G' (e.g., G_MY_GLOBAL).
Constants use upper SNAKE_CASE (e.g., MY_CONSTANT).
Avoid shadowing variables from an outer scope.
Initialize all externally visible members of a class in the constructor.
Prefer docstrings for interfaces that may be used outside a file; comments for in-function or file-local interfaces.
Use Google-style docstrings for classes and functions (Sphinx-parsable).
Document attributes and variables inline so they render under the class/function docstring.
Avoid reflection when a simpler, explicit approach suffices (e.g., avoid dict(**locals()) patterns).
In try/except, catch the most specific exceptions possible.
For duck-typing try/except, keep the try body minimal and use else for the main logic.

Files:

tests/unittest/bindings/test_hostfunc.py

**/*.{cpp,cxx,cc,h,hpp,hh,hxx,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Prepend the NVIDIA Apache-2.0 copyright header with current year to the top of all source files (e.g., .cpp, .h, .cu, .py).

Files:

tests/unittest/bindings/test_hostfunc.py

🧠 Learnings (2)

📓 Common learnings

Learnt from: tongyuantongyu
Repo: NVIDIA/TensorRT-LLM PR: 7781
File: tests/integration/test_lists/waives.txt:313-313
Timestamp: 2025-09-17T02:48:52.732Z
Learning: In TensorRT-LLM, `tests/integration/test_lists/waives.txt` is specifically for waiving/skipping tests, while other test list files like those in `test-db/` and `qa/` directories are for different test execution contexts (pre-merge, post-merge, QA tests). The same test appearing in both waives.txt and execution list files is intentional - the test is part of test suites but will be skipped due to the waiver.

Learnt from: EmmaQiaoCh
Repo: NVIDIA/TensorRT-LLM PR: 7370
File: tests/unittest/trt/model_api/test_model_quantization.py:24-27
Timestamp: 2025-08-29T14:07:45.863Z
Learning: In TensorRT-LLM's CI infrastructure, pytest skip markers (pytest.mark.skip) are properly honored even when test files have __main__ blocks that call test functions directly. The testing system correctly skips tests without requiring modifications to the __main__ block execution pattern.

Learnt from: nvpohanh
Repo: NVIDIA/TensorRT-LLM PR: 7478
File: tests/unittest/_torch/modeling/test_modeling_llama_min_latency.py:286-308
Timestamp: 2025-09-03T13:16:38.028Z
Learning: In test files, temporary monkey-patches for upstream bugs can be kept simple when they are explicitly intended to be removed soon, rather than investing effort in making them more robust.

📚 Learning: 2025-08-29T14:07:45.863Z

Learnt from: EmmaQiaoCh
Repo: NVIDIA/TensorRT-LLM PR: 7370
File: tests/unittest/trt/model_api/test_model_quantization.py:24-27
Timestamp: 2025-08-29T14:07:45.863Z
Learning: In TensorRT-LLM's CI infrastructure, pytest skip markers (pytest.mark.skip) are properly honored even when test files have __main__ blocks that call test functions directly. The testing system correctly skips tests without requiring modifications to the __main__ block execution pattern.

Applied to files:

tests/unittest/bindings/test_hostfunc.py

🧬 Code graph analysis (1)

tests/unittest/bindings/test_hostfunc.py (1)

tensorrt_llm/_torch/hostfunc.py (1)

hostfunc (22-27)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Pre-commit Check

🔇 Additional comments (2)

tests/unittest/bindings/test_hostfunc.py (2)

2-2: LGTM: Pytest import added correctly.

The pytest import is necessary for the skip marker and is properly positioned with other imports at the top of the file.

7-7: LGTM: Test skip marker applied correctly.

The skip marker is properly applied and will be honored by the CI system. The approach aligns with the PR objective of waiving failed tests for the release branch.

Optionally verify that the bug reference format https://nvbugs/5643631 is correct and accessible. If this is an internal NVIDIA convention, no action is needed.

Based on learnings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

tensorrt-cicd · 2025-11-09T03:59:55Z

PR_Github #23909 [ run ] triggered by Bot. Commit: b986e4f

tensorrt-cicd · 2025-11-09T04:28:41Z

PR_Github #23909 [ run ] completed with state FAILURE. Commit: b986e4f
/LLM/release-1.1/L0_MergeRequest_PR pipeline #456 (Partly Tested) completed with status: 'FAILURE'

Signed-off-by: qqiao <qqiao@nvidia.com>

EmmaQiaoCh · 2025-11-09T05:16:40Z

/bot run --stage-list "GH200-TensorRT-Post-Merge-1"

tensorrt-cicd · 2025-11-09T05:22:39Z

PR_Github #23911 [ run ] triggered by Bot. Commit: aeb71c0

tensorrt-cicd · 2025-11-09T07:54:46Z

PR_Github #23911 [ run ] completed with state SUCCESS. Commit: aeb71c0
/LLM/release-1.1/L0_MergeRequest_PR pipeline #457 (Partly Tested) completed with status: 'SUCCESS'

Skip failed test for release branch

b986e4f

Signed-off-by: qqiao <qqiao@nvidia.com>

EmmaQiaoCh requested a review from a team as a code owner November 9, 2025 03:54

EmmaQiaoCh requested review from ZhanruiSunCh, chzblych and yiqingy0 November 9, 2025 03:54

Fix format

aeb71c0

Signed-off-by: qqiao <qqiao@nvidia.com>

chzblych approved these changes Nov 9, 2025

View reviewed changes

chzblych merged commit a74ce26 into NVIDIA:release/1.1 Nov 9, 2025
4 of 5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[None][infra] Waive failed tests for release branch 11/07 #9026

[None][infra] Waive failed tests for release branch 11/07 #9026

Uh oh!

EmmaQiaoCh commented Nov 9, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

EmmaQiaoCh commented Nov 9, 2025

Uh oh!

coderabbitai bot commented Nov 9, 2025

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Uh oh!

tensorrt-cicd commented Nov 9, 2025

Uh oh!

tensorrt-cicd commented Nov 9, 2025

Uh oh!

EmmaQiaoCh commented Nov 9, 2025

Uh oh!

tensorrt-cicd commented Nov 9, 2025

Uh oh!

tensorrt-cicd commented Nov 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[None][infra] Waive failed tests for release branch 11/07 #9026

[None][infra] Waive failed tests for release branch 11/07 #9026

Uh oh!

Conversation

EmmaQiaoCh commented Nov 9, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Description

Test Coverage

PR Checklist

GitHub Bot Help

kill

skip

reuse-pipeline

Uh oh!

EmmaQiaoCh commented Nov 9, 2025

Uh oh!

coderabbitai bot commented Nov 9, 2025

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Pre-merge checks and finishing touches

Uh oh!

tensorrt-cicd commented Nov 9, 2025

Uh oh!

tensorrt-cicd commented Nov 9, 2025

Uh oh!

EmmaQiaoCh commented Nov 9, 2025

Uh oh!

tensorrt-cicd commented Nov 9, 2025

Uh oh!

tensorrt-cicd commented Nov 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

EmmaQiaoCh commented Nov 9, 2025 •

edited by coderabbitai bot

Loading