[TRTLLM-8785][fix] create output_dir before test begin (cherry-pick #8518) #8575

crazydemo · 2025-10-22T08:42:21Z

Summary by CodeRabbit

Tests
- Improved test directory creation for periodic reporting to prevent potential conflicts with other plugins when output directories are configured.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com>

crazydemo · 2025-10-22T08:42:54Z

/bot run --skip-test

coderabbitai · 2025-10-22T08:44:14Z

📝 Walkthrough

Walkthrough

The conftest.py file is modified to create the output directory early in pytest_configure when periodic reporting is enabled and an output directory is provided, using os.makedirs(output_dir, exist_ok=True) to prevent potential conflicts with other plugins during PeriodicJUnitXML initialization.

Changes

Cohort / File(s)	Summary
Test configuration directory creation `tests/integration/defs/conftest.py`	Added early directory creation in pytest_configure using os.makedirs(output_dir, exist_ok=True) to ensure the output directory exists before PeriodicJUnitXML initialization when periodic reporting is enabled.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5–10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The pull request description is largely incomplete and fails to meet the template requirements. The "Description" section contains only an empty comment placeholder with no explanation of the issue or solution, and the "Test Coverage" section similarly lacks any actual test information despite having a comment placeholder. While the PR checklist is marked as complete with [x], the two most critical informational sections are entirely unfilled, leaving reviewers without essential context about the change's purpose, impact, and test coverage. The author submitted the template structure without providing the required substantive content in these key sections.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The PR title "[TRTLLM-8785][fix] create output_dir before test begin (cherry-pick #8518)" follows the required template format with a valid JIRA ticket identifier, type specifier, and a clear summary. The title directly and accurately summarizes the main change from the raw summary: creating the output directory early in pytest_configure before PeriodicJUnitXML initialization. The notation about cherry-picking from PR #8518 provides helpful context without obscuring the core change. The title is concise, specific, and would allow teammates reviewing history to quickly understand the primary objective of this changeset.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 09349cc and bff2456.

📒 Files selected for processing (1)

tests/integration/defs/conftest.py (1 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

**/*.{h,hpp,hh,hxx,cpp,cxx,cc,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Use only spaces, no tabs; indent with 4 spaces.

Files:

tests/integration/defs/conftest.py

**/*.py

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

**/*.py: Python code must target Python 3.8+.
Indent Python code with 4 spaces; do not use tabs.
Maintain module namespace when importing; prefer 'from package.subpackage import foo' then 'foo.SomeClass()' instead of importing the class directly.
Python filenames should be snake_case (e.g., some_file.py).
Python classes use PascalCase names.
Functions and methods use snake_case names.
Local variables use snake_case; prefix 'k' for variables that start with a number (e.g., k_99th_percentile).
Global variables use upper SNAKE_CASE prefixed with 'G' (e.g., G_MY_GLOBAL).
Constants use upper SNAKE_CASE (e.g., MY_CONSTANT).
Avoid shadowing variables from an outer scope.
Initialize all externally visible members of a class in the constructor.
Prefer docstrings for interfaces that may be used outside a file; comments for in-function or file-local interfaces.
Use Google-style docstrings for classes and functions (Sphinx-parsable).
Document attributes and variables inline so they render under the class/function docstring.
Avoid reflection when a simpler, explicit approach suffices (e.g., avoid dict(**locals()) patterns).
In try/except, catch the most specific exceptions possible.
For duck-typing try/except, keep the try body minimal and use else for the main logic.

Files:

tests/integration/defs/conftest.py

**/*.{cpp,cxx,cc,h,hpp,hh,hxx,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Prepend the NVIDIA Apache-2.0 copyright header with current year to the top of all source files (e.g., .cpp, .h, .cu, .py).

Files:

tests/integration/defs/conftest.py

🧬 Code graph analysis (1)

tests/integration/defs/conftest.py (1)

tests/integration/defs/triton_server/conftest.py (1)

output_dir (652-656)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Pre-commit Check

🔇 Additional comments (1)

tests/integration/defs/conftest.py (1)

2211-2214: LGTM! Early directory creation prevents plugin conflicts.

The eager creation of the output directory during pytest_configure is appropriate. Using exist_ok=True ensures idempotency and prevents conflicts with the existing output_dir fixture (lines 653-657), which creates the directory lazily. This change addresses potential race conditions with plugins like pytest-split that may need the directory before test fixtures are initialized.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

tensorrt-cicd · 2025-10-22T08:48:23Z

PR_Github #22162 [ run ] triggered by Bot. Commit: bff2456

tensorrt-cicd · 2025-10-22T11:40:29Z

PR_Github #22162 [ run ] completed with state SUCCESS. Commit: bff2456
/LLM/release-1.1/L0_MergeRequest_PR pipeline #224 (Partly Tested) completed with status: 'SUCCESS'

crazydemo · 2025-10-23T08:09:43Z

/bot reuse-pipeline

tensorrt-cicd · 2025-10-23T08:17:16Z

PR_Github #22273 [ reuse-pipeline ] triggered by Bot. Commit: bff2456

tensorrt-cicd · 2025-10-23T08:41:52Z

PR_Github #22273 [ reuse-pipeline ] completed with state SUCCESS. Commit: bff2456
Reusing PR_Github #22162 (Partly Tested) for commit bff2456

crazydemo requested a review from a team as a code owner October 22, 2025 08:42

crazydemo requested a review from LarryXFly October 22, 2025 08:42

create output_dir before test begin

bff2456

Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com>

crazydemo force-pushed the save_runtime_report_for_release branch from 231b11d to bff2456 Compare October 22, 2025 08:42

LarryXFly approved these changes Oct 22, 2025

View reviewed changes

LarryXFly enabled auto-merge (squash) October 22, 2025 08:52

LarryXFly merged commit 5d27034 into NVIDIA:release/1.1 Oct 23, 2025
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[TRTLLM-8785][fix] create output_dir before test begin (cherry-pick #8518) #8575

[TRTLLM-8785][fix] create output_dir before test begin (cherry-pick #8518) #8575

Uh oh!

crazydemo commented Oct 22, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

crazydemo commented Oct 22, 2025

Uh oh!

coderabbitai bot commented Oct 22, 2025 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Uh oh!

tensorrt-cicd commented Oct 22, 2025

Uh oh!

tensorrt-cicd commented Oct 22, 2025

Uh oh!

crazydemo commented Oct 23, 2025

Uh oh!

tensorrt-cicd commented Oct 23, 2025

Uh oh!

tensorrt-cicd commented Oct 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[TRTLLM-8785][fix] create output_dir before test begin (cherry-pick #8518) #8575

[TRTLLM-8785][fix] create output_dir before test begin (cherry-pick #8518) #8575

Uh oh!

Conversation

crazydemo commented Oct 22, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Description

Test Coverage

PR Checklist

GitHub Bot Help

kill

skip

reuse-pipeline

Uh oh!

crazydemo commented Oct 22, 2025

Uh oh!

coderabbitai bot commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Pre-merge checks and finishing touches

Uh oh!

tensorrt-cicd commented Oct 22, 2025

Uh oh!

tensorrt-cicd commented Oct 22, 2025

Uh oh!

crazydemo commented Oct 23, 2025

Uh oh!

tensorrt-cicd commented Oct 23, 2025

Uh oh!

tensorrt-cicd commented Oct 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

crazydemo commented Oct 22, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Oct 22, 2025 •

edited

Loading