Skip to content

[None][doc] Fix the incorrect doc figure #8536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Shixiaowei02 merged 2 commits into from
Oct 22, 2025
Merged

[None][doc] Fix the incorrect doc figure #8536

Shixiaowei02 merged 2 commits into from
Oct 22, 2025

Conversation

@Shixiaowei02
Copy link
Collaborator

@Shixiaowei02 Shixiaowei02 commented Oct 21, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Documentation
    • Updated image reference in the KV transfer overview guide to reflect current documentation.

@Shixiaowei02
fix: incorrect doc figure
ecea659 
Signed-off-by: Shixiaowei02 <39303645+Shixiaowei02@users.noreply.github.com>
@Shixiaowei02 Shixiaowei02 requested a review from a team as a code owner October 21, 2025 12:13
@Shixiaowei02
Copy link
Collaborator Author

Shixiaowei02 commented Oct 21, 2025

/bot skip --comment "doc changes"

@Shixiaowei02 Shixiaowei02 changed the title fix: incorrect doc figure [None][doc] Fix the incorrect doc figure Oct 21, 2025
@Shixiaowei02 Shixiaowei02 enabled auto-merge (squash) October 21, 2025 12:14
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 21, 2025

📝 Walkthrough

Walkthrough

Updated the image URL in the KV transfer documentation from the rel branch to the main branch. This modifies the source reference for an embedded workflow overview image without altering any documentation content or logic.

Changes

Cohort / File(s) Change Summary
Documentation image reference
docs/source/developer-guide/kv-transfer.md		 Updated image URL in Workflow section from rel branch to main branch

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description is entirely missing. According to the repository's description template, the PR should include three main sections: a description explaining the issue and solution, a test coverage section listing relevant tests, and a PR checklist confirming that guidelines and requirements have been met. Without any description provided by the author, all required sections are absent or incomplete, making it impossible to understand the context, rationale, and testing approach for the change. Please add a pull request description that includes: a brief explanation of the issue (incorrect doc figure) and the solution (updating the image URL from rel branch to main branch), a test coverage section explaining how this documentation change is validated, and completion of the PR checklist items. Even for documentation-only changes, providing this context helps reviewers understand the scope and ensures all guidelines have been followed.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title follows the correct template format with [None][doc] indicating no ticket reference and a documentation type change. The title "Fix the incorrect doc figure" is concise, clear, and directly relates to the main change in the pull request, which is updating an image URL in the KV transfer documentation file. The title accurately summarizes the primary change without being vague or generic.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a0024f4 and ecea659.

📒 Files selected for processing (1)
  • docs/source/developer-guide/kv-transfer.md (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (1)
docs/source/developer-guide/kv-transfer.md (1)

21-21: Image URL verified and change is correct.

The image file exists at the new location in the NVIDIA/TensorRT-LLM repository main branch. The URL format is correct and maintains proper GitHub raw content serving. This documentation update is valid with no issues identified.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented Oct 21, 2025

PR_Github #22053 [ skip ] triggered by Bot. Commit: ecea659

@Shixiaowei02
update
dc95dbf 
Signed-off-by: Shixiaowei02 <39303645+Shixiaowei02@users.noreply.github.com>
@Shixiaowei02 Shixiaowei02 requested a review from a team as a code owner October 21, 2025 12:26
@Shixiaowei02
Copy link
Collaborator Author

Shixiaowei02 commented Oct 21, 2025

/bot skip --comment "doc changes"

@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented Oct 21, 2025

PR_Github #22055 [ skip ] triggered by Bot. Commit: dc95dbf

@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented Oct 21, 2025

PR_Github #22053 [ skip ] completed with state ABORTED. Commit: ecea659

@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented Oct 21, 2025

PR_Github #22055 [ skip ] completed with state SUCCESS. Commit: dc95dbf
Skipping testing for commit dc95dbf

QiJune
QiJune approved these changes Oct 22, 2025
View reviewed changes
Copy link
Collaborator

@QiJune QiJune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Shixiaowei02 Shixiaowei02 merged commit 50149ac into NVIDIA:main Oct 22, 2025
5 checks passed
@Shixiaowei02 Shixiaowei02 deleted the user/xiaoweis/doc-update branch October 22, 2025 06:26
yufeiwu-nv pushed a commit to yufeiwu-nv/TensorRT-LLM that referenced this pull request Oct 24, 2025
@Shixiaowei02 @yufeiwu-nv
[None][doc] Fix the incorrect doc figure (NVIDIA#8536)
4e5b162 
Signed-off-by: Shixiaowei02 <39303645+Shixiaowei02@users.noreply.github.com>
Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 1, 2025
@Shixiaowei02 @dominicshanshan
[None][doc] Fix the incorrect doc figure (NVIDIA#8536)
730f32f 
Signed-off-by: Shixiaowei02 <39303645+Shixiaowei02@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025
@Shixiaowei02 @dominicshanshan
[None][doc] Fix the incorrect doc figure (NVIDIA#8536)
bdc50bb 
Signed-off-by: Shixiaowei02 <39303645+Shixiaowei02@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025
@Shixiaowei02 @dominicshanshan
[None][doc] Fix the incorrect doc figure (NVIDIA#8536)
2ce2d29 
Signed-off-by: Shixiaowei02 <39303645+Shixiaowei02@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025
@Shixiaowei02 @dominicshanshan
[None][doc] Fix the incorrect doc figure (NVIDIA#8536)
9ee44cc 
Signed-off-by: Shixiaowei02 <39303645+Shixiaowei02@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tabrizian Tabrizian Tabrizian approved these changes

@QiJune QiJune QiJune approved these changes

@laikhtewari laikhtewari Awaiting requested review from laikhtewari laikhtewari is a code owner automatically assigned from NVIDIA/trt-llm-doc-owners

@nv-guomingz nv-guomingz Awaiting requested review from nv-guomingz nv-guomingz is a code owner automatically assigned from NVIDIA/trt-llm-doc-owners

@chuangz0 chuangz0 Awaiting requested review from chuangz0 chuangz0 is a code owner automatically assigned from NVIDIA/trt-llm-disagg-devs

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Shixiaowei02 @tensorrt-cicd @Tabrizian @QiJune