Skip to content

Conversation

@venkywonka
Copy link
Collaborator

@venkywonka venkywonka commented Oct 17, 2025

Summary by CodeRabbit

  • Chores
    • Updated license attribution files included in package distributions to provide architecture-specific information.
    • This is needed because there have been changes in copyright and contribution information for the libraries release for aarch64 platform. The prior ATTRIBUTIONS-CPP.md was consolidated for x86_64.
    • The following attributions changed in aarch64 as compiled by @tburt-nv :
      • libzmq:
        • 1 extra contributor (Brett Viren) for libzmq
        • 1 less (Laurent Alebarde)
        • License changed from GPLv3 to MPLv2
      • OpenMPI
        • Added a copyright line (Copyright (c) 2020-2021 Cornelis Networks, Inc. All rights reserved.)

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@venkywonka venkywonka requested a review from a team as a code owner October 17, 2025 23:24
@coderabbitai coderabbitai bot changed the title [None] @coderabbitai title [None] [chore] Add architecture-specific license files Oct 17, 2025
Signed-off-by: Venky Ganesh <23023424+venkywonka@users.noreply.github.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 17, 2025

📝 Walkthrough

Walkthrough

The license_files parameter in the setup() function call within setup.py has been updated to replace a single generic ATTRIBUTIONS-CPP file with two architecture-specific variants: one for x86_64 and one for aarch64.

Changes

Cohort / File(s) Summary
License Configuration
setup.py
Updated license_files parameter from ["LICENSE", "ATTRIBUTIONS-CPP.md"] to ["LICENSE", "ATTRIBUTIONS-CPP-x86_64.md", "ATTRIBUTIONS-CPP-aarch64.md"]

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • atrifex
  • tongyuantongyu
  • schetlur-nv
  • yuanjingx87
  • juney-nvidia

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description is largely incomplete and contains only the repository's template structure with empty placeholder sections. The PR title remains as a literal placeholder "[None] @coderabbitai title" rather than being replaced with an actual formatted title. Critical sections are entirely unfilled: the Description section is empty (no explanation of the issue or solution provided), and the Test Coverage section is empty (no test cases mentioned despite the change affecting setup.py's license file configuration). While the PR Checklist framework is present, the required content needed to explain the changes and justify the testing approach is missing entirely. The author must complete the PR description by providing: (1) a properly formatted PR title following the template "[ticket/issue/None][type] Summary" with an actual type and description, (2) a filled Description section explaining why the license_files list in setup.py was expanded from two files to three files, and (3) a Test Coverage section listing what tests verify this change. The PR Checklist items should be reviewed and checked as appropriate to confirm the change meets project standards.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Title Check ✅ Passed The PR title "[None] [chore] Add architecture-specific ATTRIBUTIONS files" follows the required format with the [None] ticket identifier and [chore] type indicator. The title accurately summarizes the main change shown in the raw summary: the license_files parameter in setup.py is being expanded from a single ATTRIBUTIONS-CPP.md file to architecture-specific files (ATTRIBUTIONS-CPP-x86_64.md and ATTRIBUTIONS-CPP-aarch64.md). The title is clear, concise, and directly related to the changeset without being vague or overly broad.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@venkywonka venkywonka force-pushed the venky/add-attributions branch from f83a476 to d636973 Compare October 17, 2025 23:28
@venkywonka venkywonka changed the title [None] [chore] Add architecture-specific license files [None] [chore] Add architecture-specific ATTRIBUTIONS files Oct 17, 2025
@venkywonka venkywonka self-assigned this Oct 17, 2025
@venkywonka
Copy link
Collaborator Author

/bot run --skip-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21733 [ run ] triggered by Bot. Commit: d636973

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21733 [ run ] completed with state SUCCESS. Commit: d636973
/LLM/main/L0_MergeRequest_PR pipeline #16377 (Partly Tested) completed with status: 'SUCCESS'

@juney-nvidia juney-nvidia enabled auto-merge (squash) October 19, 2025 08:07
@venkywonka
Copy link
Collaborator Author

Verified by downloading and looking at the wheels generated in above pipeline that all the attribution files are included.

Signed-off-by: Venky Ganesh <23023424+venkywonka@users.noreply.github.com>
Signed-off-by: Venky Ganesh <23023424+venkywonka@users.noreply.github.com>
Signed-off-by: Venky Ganesh <23023424+venkywonka@users.noreply.github.com>
@venkywonka
Copy link
Collaborator Author

/bot run --skip-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21938 [ run ] triggered by Bot. Commit: 750a512

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21938 [ run ] completed with state SUCCESS. Commit: 750a512
/LLM/main/L0_MergeRequest_PR pipeline #16537 (Partly Tested) completed with status: 'SUCCESS'

@venkywonka
Copy link
Collaborator Author

/bot skip --comment "No L0, verified in #16537, using skip-test that the test added run and passed"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21945 [ skip ] triggered by Bot. Commit: 750a512

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21945 [ skip ] completed with state SUCCESS. Commit: 750a512
Skipping testing for commit 750a512

@juney-nvidia juney-nvidia merged commit 3e681e2 into NVIDIA:main Oct 20, 2025
5 checks passed
govind-ramnarayan pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request Oct 21, 2025
)

Signed-off-by: Venky Ganesh <23023424+venkywonka@users.noreply.github.com>
yufeiwu-nv pushed a commit to yufeiwu-nv/TensorRT-LLM that referenced this pull request Oct 24, 2025
)

Signed-off-by: Venky Ganesh <23023424+venkywonka@users.noreply.github.com>
Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 1, 2025
)

Signed-off-by: Venky Ganesh <23023424+venkywonka@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025
)

Signed-off-by: Venky Ganesh <23023424+venkywonka@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025
)

Signed-off-by: Venky Ganesh <23023424+venkywonka@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025
)

Signed-off-by: Venky Ganesh <23023424+venkywonka@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants