[TRTLLM-8669][infra] Use artifactory mirror for install python #8394

ZhanruiSunCh · 2025-10-15T09:46:06Z

As this test result PR_Github #21560
The 4 build stage finished without any retry. The mirror is useful.

Summary by CodeRabbit

New Features
- Added optional mirror support for Python downloads when a mirror is configured, improving reliability and potential download speeds in restricted or internal network environments.
Chores
- Updated installation logic to conditionally switch the Python download source based on configuration, while preserving the existing workflow and defaults.
- Ensures no change for standard installations; the alternate source is only used when explicitly configured.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

ZhanruiSunCh · 2025-10-15T09:46:24Z

/bot run --stage-list "Build-Docker-Images"

coderabbitai · 2025-10-15T09:46:30Z

📝 Walkthrough

Walkthrough

Adds a conditional in install_python_rockylinux to override PYTHON_URL when GITHUB_MIRROR is set, switching downloads from the official Python URL to an Nvidia/GitHub mirror. The rest of the function’s flow (dnf cache refresh, package installation) remains unchanged.

Changes

Cohort / File(s)	Summary of Changes
Python download URL override `docker/common/install_base.sh`	Added conditional to set PYTHON_URL to a GitHub mirror when GITHUB_MIRROR is present; otherwise uses the default official Python URL. No other logic modified.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant U as Invoker
  participant S as install_python_rockylinux
  participant E as Env
  participant P as Python Download Source
  participant D as dnf

  U->>S: Call install_python_rockylinux
  S->>E: Check GITHUB_MIRROR
  alt GITHUB_MIRROR set
    Note right of S: Override PYTHON_URL to mirror
    S->>P: Set URL = Nvidia/GitHub mirror
  else Not set
    Note right of S: Use official Python URL
    S->>P: Set URL = official python.org
  end
  rect rgba(200,230,255,0.2)
    S->>D: Refresh dnf cache and install deps
  end
  S->>P: Download Python from PYTHON_URL
  S-->>U: Continue with installation flow

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.
Description Check	⚠️ Warning	The pull request description does not follow the required template and leaves key sections empty, including the Title, Description, and Test Coverage fields which remain as placeholders without content. Only a brief note about CI results is provided, and no explanation of the change or associated tests is included. The PR Checklist has not been completed beyond a single confirmation, so the description is incomplete.	Please update the PR description to include a properly formatted title following the template, provide a concise Description of the change and its rationale, list relevant Test Coverage details, and mark off all items in the PR Checklist as appropriate.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title succinctly identifies the JIRA ticket, labels the change as infrastructure, and describes the primary update of using an Artifactory mirror for Python installation, accurately reflecting the main change in the pull request.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

tensorrt-cicd · 2025-10-15T09:53:25Z

PR_Github #21467 [ run ] triggered by Bot

ZhanruiSunCh · 2025-10-15T10:23:48Z

/bot run --stage-list "Build-Docker-Images"

tensorrt-cicd · 2025-10-15T10:29:04Z

PR_Github #21471 [ run ] triggered by Bot

tensorrt-cicd · 2025-10-15T10:29:05Z

PR_Github #21467 [ run ] completed with state ABORTED
LLM/main/L0_MergeRequest_PR #16206 (Blue Ocean) completed with status: ABORTED

tensorrt-cicd · 2025-10-15T18:05:45Z

PR_Github #21471 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #16210 (Partly Tested) completed with status: 'FAILURE'

ZhanruiSunCh · 2025-10-16T06:40:22Z

/bot run --stage-list "Build-Docker-Images"

tensorrt-cicd · 2025-10-16T06:45:59Z

PR_Github #21545 [ run ] triggered by Bot

ZhanruiSunCh · 2025-10-16T08:11:11Z

/bot run --stage-list "Build-Docker-Images"

tensorrt-cicd · 2025-10-16T08:16:40Z

PR_Github #21556 [ run ] triggered by Bot

tensorrt-cicd · 2025-10-16T08:16:43Z

PR_Github #21545 [ run ] completed with state ABORTED
LLM/main/L0_MergeRequest_PR #16265 (Blue Ocean) completed with status: ABORTED

ZhanruiSunCh · 2025-10-16T08:36:33Z

/bot run --stage-list "Build-Docker-Images"

tensorrt-cicd · 2025-10-16T08:42:14Z

PR_Github #21560 [ run ] triggered by Bot

tensorrt-cicd · 2025-10-16T08:42:16Z

PR_Github #21556 [ run ] completed with state ABORTED
LLM/main/L0_MergeRequest_PR #16272 (Blue Ocean) completed with status: ABORTED

docker/common/install_base.sh

ZhanruiSunCh · 2025-10-16T13:49:19Z

/bot run --stage-list "Build-Docker-Images"

tensorrt-cicd · 2025-10-16T13:54:35Z

PR_Github #21581 [ run ] triggered by Bot

tensorrt-cicd · 2025-10-16T13:54:36Z

PR_Github #21581 [ run ] completed with state DISABLED
L0 testing is limited to prioritized users. User ZhanruiSunCh is not in the prioritized list. L0 testing cannot be triggered.

chzblych · 2025-10-19T08:28:46Z

/bot run --stage-list "Build-Docker-Images"

tensorrt-cicd · 2025-10-19T08:34:25Z

PR_Github #21794 [ run ] triggered by Bot. Commit: 193b60f

Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>

Co-authored-by: Yanchao Lu <yanchaol@nvidia.com> Signed-off-by: Zhanrui Sun <184402041+ZhanruiSunCh@users.noreply.github.com>

Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>

Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>

…fer_builder_resource_win.so Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>

ZhanruiSunCh · 2025-10-19T15:31:39Z

/bot run --stage-list "Build-Docker-Images"

tensorrt-cicd · 2025-10-19T15:36:59Z

PR_Github #21811 [ run ] triggered by Bot. Commit: 8414eee

tensorrt-cicd · 2025-10-19T15:37:00Z

PR_Github #21794 [ run ] completed with state ABORTED. Commit: 193b60f
LLM/main/L0_MergeRequest_PR #16429 (Blue Ocean) completed with status: ABORTED

ZhanruiSunCh · 2025-10-20T03:57:01Z

/bot skip --comment "Images build passed, mirror is working"

tensorrt-cicd · 2025-10-20T04:02:10Z

PR_Github #21843 [ skip ] triggered by Bot. Commit: 8414eee

tensorrt-cicd · 2025-10-20T04:02:12Z

PR_Github #21811 [ run ] completed with state ABORTED. Commit: 8414eee
LLM/main/L0_MergeRequest_PR #16440 (Blue Ocean) completed with status: ABORTED

tensorrt-cicd · 2025-10-20T04:17:08Z

PR_Github #21843 [ skip ] completed with state SUCCESS. Commit: 8414eee
Skipping testing for commit 8414eee

…A#8394) Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com> Signed-off-by: Zhanrui Sun <184402041+ZhanruiSunCh@users.noreply.github.com> Signed-off-by: Yanchao Lu <yanchaol@nvidia.com> Co-authored-by: Yanchao Lu <yanchaol@nvidia.com>

…A#8394) Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com> Signed-off-by: Zhanrui Sun <184402041+ZhanruiSunCh@users.noreply.github.com> Signed-off-by: Yanchao Lu <yanchaol@nvidia.com> Co-authored-by: Yanchao Lu <yanchaol@nvidia.com> Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>

…A#8394) Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com> Signed-off-by: Zhanrui Sun <184402041+ZhanruiSunCh@users.noreply.github.com> Signed-off-by: Yanchao Lu <yanchaol@nvidia.com> Co-authored-by: Yanchao Lu <yanchaol@nvidia.com>

ZhanruiSunCh requested review from a team as code owners October 15, 2025 09:46

ZhanruiSunCh requested review from Shixiaowei02 and ruodil October 15, 2025 09:46

ZhanruiSunCh requested a review from a team as a code owner October 16, 2025 08:10

ZhanruiSunCh force-pushed the user/zhanruis/1015_use_mirror_for_python_install_in_docker_build_images branch from bbfc919 to 5155d6e Compare October 16, 2025 08:36

ZhanruiSunCh requested review from EmmaQiaoCh, chzblych, niukuo and yiqingy0 October 16, 2025 09:14

chzblych approved these changes Oct 16, 2025

View reviewed changes

docker/common/install_base.sh Outdated Show resolved Hide resolved

ZhanruiSunCh force-pushed the user/zhanruis/1015_use_mirror_for_python_install_in_docker_build_images branch from ce540c7 to 6c1b1fe Compare October 16, 2025 13:49

chzblych force-pushed the user/zhanruis/1015_use_mirror_for_python_install_in_docker_build_images branch from 5daad8c to 193b60f Compare October 19, 2025 08:23

ZhanruiSunCh and others added 11 commits October 19, 2025 08:27

[TRTLLM-8669][infra] Use artifactory mirror for install python

f989d98

Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>

Use artifactory mirror for pip install in build docker images

3541078

Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>

Fix file name error

90cb949

Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>

Update docker/common/install_base.sh

fbbdc56

Co-authored-by: Yanchao Lu <yanchaol@nvidia.com> Signed-off-by: Zhanrui Sun <184402041+ZhanruiSunCh@users.noreply.github.com>

Fix review

71ae242

Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>

Fix review

db080d5

Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>

Update docker/common/install_base.sh

3ea664d

Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>

Update docker/common/install_nixl.sh

8919c03

Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>

Update docker/Dockerfile.multi

e1c2478

Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>

Update docker/common/install_polygraphy.sh

4ebd0b6

Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>

Add internal gitlab mirror for nixl and ucx, use wildcard for libnvin…

8414eee

…fer_builder_resource_win.so Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>

ZhanruiSunCh force-pushed the user/zhanruis/1015_use_mirror_for_python_install_in_docker_build_images branch from 75b0a94 to 8414eee Compare October 19, 2025 15:30

ZhanruiSunCh enabled auto-merge (squash) October 20, 2025 03:57

ZhanruiSunCh merged commit 8124a62 into NVIDIA:main Oct 20, 2025
5 checks passed

[TRTLLM-8669][infra] Use artifactory mirror for install python #8394

[TRTLLM-8669][infra] Use artifactory mirror for install python #8394

Uh oh!

Conversation

ZhanruiSunCh commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Description

Test Coverage

PR Checklist

GitHub Bot Help

kill

skip

reuse-pipeline

Uh oh!

ZhanruiSunCh commented Oct 15, 2025

Uh oh!

coderabbitai bot commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Pre-merge checks and finishing touches

Uh oh!

tensorrt-cicd commented Oct 15, 2025

Uh oh!

ZhanruiSunCh commented Oct 15, 2025

Uh oh!

tensorrt-cicd commented Oct 15, 2025

Uh oh!

tensorrt-cicd commented Oct 15, 2025

Uh oh!

tensorrt-cicd commented Oct 15, 2025

Uh oh!

ZhanruiSunCh commented Oct 16, 2025

Uh oh!

tensorrt-cicd commented Oct 16, 2025

Uh oh!

ZhanruiSunCh commented Oct 16, 2025

Uh oh!

tensorrt-cicd commented Oct 16, 2025

Uh oh!

tensorrt-cicd commented Oct 16, 2025

Uh oh!

ZhanruiSunCh commented Oct 16, 2025

Uh oh!

tensorrt-cicd commented Oct 16, 2025

Uh oh!

tensorrt-cicd commented Oct 16, 2025

Uh oh!

Uh oh!

ZhanruiSunCh commented Oct 16, 2025

Uh oh!

tensorrt-cicd commented Oct 16, 2025

Uh oh!

tensorrt-cicd commented Oct 16, 2025

Uh oh!

chzblych commented Oct 19, 2025

Uh oh!

tensorrt-cicd commented Oct 19, 2025

Uh oh!

ZhanruiSunCh commented Oct 19, 2025

Uh oh!

tensorrt-cicd commented Oct 19, 2025

Uh oh!

tensorrt-cicd commented Oct 19, 2025

Uh oh!

ZhanruiSunCh commented Oct 20, 2025

Uh oh!

tensorrt-cicd commented Oct 20, 2025

Uh oh!

tensorrt-cicd commented Oct 20, 2025

Uh oh!

tensorrt-cicd commented Oct 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

ZhanruiSunCh commented Oct 15, 2025 •

edited

Loading

coderabbitai bot commented Oct 15, 2025 •

edited

Loading