Skip to content

Conversation

@HuiGao-NV
Copy link
Collaborator

@HuiGao-NV HuiGao-NV commented Sep 24, 2025

Summary by CodeRabbit

  • Tests

    • Expanded the test waiver list to skip additional DeepSeek-related scenarios (including specific backends, multi-GPU, and variant cases), reducing false negatives and stabilizing CI runs.
  • Chores

    • Improved CI reliability by marking more known-problematic tests as skipped, reducing noise in integration test results.
  • Documentation

    • No user-facing documentation changes.
  • New Features / Bug Fixes

    • No functional changes; application behavior and APIs remain unchanged.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Signed-off-by: Hui Gao <huig@nvidia.com>
@HuiGao-NV HuiGao-NV requested a review from Superjomn September 24, 2025 09:06
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 24, 2025

📝 Walkthrough

Walkthrough

Added multiple SKIP entries to tests/integration/test_lists/waives.txt to expand the test waiver list for DeepSeek-related scenarios (e.g., moe_backend=CUTLASS, multi-GPU, and specific variants). No code or control-flow changes.

Changes

Cohort / File(s) Summary of changes
Test skip waivers
tests/integration/test_lists/waives.txt
Appended SKIP lines for DeepSeek and related tests with nvbugs references, covering CUTLASS MoE backend, multi-GPU, and specific variants. No other files changed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description is essentially the repository template and a CodeRabbit placeholder with no filled content; it lacks a proper PR title in the required "[ticket][type] Summary" format, a concrete Description explaining what changed and why, and a Test Coverage section listing relevant tests or waivers. The submission does not document the rationale for waiving tests, the exact lines added to the waiver file, or any related NVBugs/JIRA references, so it is largely incomplete against the repository's template requirements. Based on these omissions the description cannot be accepted as-is. Please replace the placeholder/template with a real PR title using the required "[ticket][type] Summary" format and fill the Description with a concise explanation of the changes (which tests were waived and why), include links to any NVBugs/JIRA issues, and populate the Test Coverage section with relevant tests and verification steps; also confirm checklist items or explain exceptions. If helpful, use the CodeRabbit AI helper to generate the title/summary but ensure all template sections are completed before requesting review.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title "[None][ci] Waive some intermittent failures" is concise and accurately summarizes the primary change—adding waivers for intermittent CI test failures—and aligns with the changeset that adds SKIP entries to tests/integration/test_lists/waives.txt.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@HuiGao-NV HuiGao-NV requested a review from QiJune September 24, 2025 09:10
Copy link
Collaborator

@Superjomn Superjomn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@QiJune QiJune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HuiGao-NV
Copy link
Collaborator Author

/bot skip --comment "Only waive test cases"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #19789 [ skip ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #19789 [ skip ] completed with state SUCCESS
Skipping testing for commit 0c29991

@HuiGao-NV HuiGao-NV merged commit c8bda4b into NVIDIA:main Sep 24, 2025
5 checks passed
@HuiGao-NV HuiGao-NV deleted the waive_intermittent_failures branch October 13, 2025 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants