Skip to content

[None][fix] Fix DeepGEMM commit #7875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yuxianq merged 1 commit into from
Sep 22, 2025
Merged

[None][fix] Fix DeepGEMM commit #7875

yuxianq merged 1 commit into from
Sep 22, 2025

Conversation

@Barry-Delaney
Copy link
Collaborator

@Barry-Delaney Barry-Delaney commented Sep 19, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Chores
    • Updated the bundled DeepGEMM third-party dependency to a newer revision.
    • No changes to the public API or user-facing functionality.
    • Routine dependency maintenance to keep the project up to date.

@Barry-Delaney
Copy link
Collaborator Author

Barry-Delaney commented Sep 19, 2025

/bot run

@Barry-Delaney Barry-Delaney assigned yuxianq and unassigned yuxianq Sep 19, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 19, 2025

📝 Walkthrough

Walkthrough

Updated the 3rdparty/DeepGEMM submodule reference from commit 67e3c4d to 0315934; no other files changed.

Changes

Cohort / File(s) Summary
Submodule update
3rdparty/DeepGEMM		 Submodule pointer updated from 67e3c4d3d09b59405fd6e7698a33db747ed96533 to 0315934ce27c5c0b05dfff1a5eb101a5f8872cfe

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR body contains only the "@coderabbitai summary" placeholder and does not fill the required sections from the repository template (Description, Test Coverage, PR Checklist), so it lacks the explanation of the change, rationale, and test information needed for review. Please expand the PR description to include a clear "Description" explaining the DeepGEMM submodule pointer change and why it was made, a "Test Coverage" section listing relevant tests or stating why none are required, and a completed "PR Checklist" (license/dependency scan, CODEOWNERS, docs, etc.), and include the specific DeepGEMM commit SHAs referenced for reviewer verification.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title "[None][fix] Fix DeepGEMM commit" concisely reflects the primary change in the changeset (a DeepGEMM submodule pointer update) and follows the repository's title template by including the ticket placeholder and type, so it clearly communicates the main change to reviewers.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fbe325c and 1305de4.

📒 Files selected for processing (1)
  • 3rdparty/DeepGEMM (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (1)
3rdparty/DeepGEMM (1)

1-1: Submodule bump — pinned commit not found upstream; verify SHA/URL & CI submodule fetch

.gitmodules: 3rdparty/DeepGEMM -> https://github.com/ruoqianguo/DeepGEMM.git; pinned SHA = 0315934ce27c5c0b05dfff1a5eb101a5f8872cfe. A GitHub API check returned 404 (commit not found) and the script exited before repo-wide grep and CI checks ran.

  • Confirm the pinned SHA exists in the referenced upstream (or update to the correct fork/private repo if applicable).
  • Ensure CI workflows fetch submodules (actions/checkout submodules:true or explicit git submodule init/update).
  • Add a one-line PR body linking the upstream commit/changelog for traceability.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented Sep 19, 2025

PR_Github #19361 [ run ] triggered by Bot

@Barry-Delaney
Fix DeepGEMM commit
fe9fa32 
Signed-off-by: Barry Kang <43644113+Barry-Delaney@users.noreply.github.com>
@Barry-Delaney Barry-Delaney force-pushed the user/barry/fix_dg_commit branch from 1305de4 to fe9fa32 Compare September 22, 2025 01:25
@Barry-Delaney
Copy link
Collaborator Author

Barry-Delaney commented Sep 22, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented Sep 22, 2025

PR_Github #19460 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented Sep 22, 2025

PR_Github #19460 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #14629 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@yuxianq yuxianq merged commit 8484aa9 into NVIDIA:main Sep 22, 2025
5 checks passed
JunyiXu-nv pushed a commit to JunyiXu-nv/TensorRT-LLM that referenced this pull request Sep 22, 2025
@Barry-Delaney @JunyiXu-nv
[None][fix] Fix DeepGEMM commit (NVIDIA#7875)
33b7ff3 
Signed-off-by: Barry Kang <43644113+Barry-Delaney@users.noreply.github.com>
nv-lschneider pushed a commit to nv-lschneider/TensorRT-LLM that referenced this pull request Sep 22, 2025
@Barry-Delaney @nv-lschneider
[None][fix] Fix DeepGEMM commit (NVIDIA#7875)
4e68312 
Signed-off-by: Barry Kang <43644113+Barry-Delaney@users.noreply.github.com>
@coderabbitai coderabbitai bot mentioned this pull request Oct 20, 2025
Merged
1 task
@coderabbitai coderabbitai bot mentioned this pull request Nov 21, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuxianq yuxianq yuxianq approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Barry-Delaney @tensorrt-cicd @yuxianq