[None][ci] Waive llama3 auto dtype test bug in https://nvbugs/5527956. #7853

dominicshanshan · 2025-09-19T02:58:44Z

Summary by CodeRabbit

Tests
- Updated integration test waivers to skip a specific failing case, improving CI stability, reducing noise in reports, and speeding up pipelines. No impact on features or performance.
Chores
- No user-facing changes or modifications to public APIs. No action required from users.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

dominicshanshan · 2025-09-19T03:08:35Z

/bot run

dominicshanshan · 2025-09-19T03:13:13Z

/bot run

dominicshanshan · 2025-09-19T05:47:06Z

/bot run

tensorrt-cicd · 2025-09-19T05:54:57Z

PR_Github #19291 [ run ] triggered by Bot

Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>

Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>

chzblych · 2025-09-19T06:35:45Z

/bot skip --comment "Test waive"

coderabbitai · 2025-09-19T06:39:06Z

📝 Walkthrough

Walkthrough

Added a new SKIP entry for accuracy/test_llm_api_autodeploy.py::TestLlama3_1_8B::test_auto_dtype in tests/integration/test_lists/waives.txt referencing nvbugs/5527956. No other files or declarations changed.

Changes

Cohort / File(s)	Summary of Changes
Test waives list `tests/integration/test_lists/waives.txt`	Appended SKIP entry for accuracy/test_llm_api_autodeploy.py::TestLlama3_1_8B::test_auto_dtype with bug reference (https://nvbugs/5527956).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

EmmaQiaoCh

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The PR description is largely the unmodified template and does not explain the actual change, missing a filled "Description" and "Test Coverage" that state what was changed (which file/line), why the waiver is necessary, and how it was validated, so reviewers lack the context needed to evaluate the change.	Please update the PR description to explicitly describe the change (e.g., added a SKIP entry for accuracy/test_llm_api_autodeploy.py::TestLlama3_1_8B::test_auto_dtype in tests/integration/test_lists/waives.txt), reference NVBugs 5527956, explain the rationale and expected revert conditions, and populate the "Test Coverage" section with the validation steps and relevant tests; confirm the PR checklist items are addressed before merging.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The PR title "[None][ci] Waive llama3 auto dtype test bug in https://nvbugs/5527956." accurately and concisely summarizes the primary change — adding a waiver/skip for the llama3 auto-dtype test referencing NVBugs 5527956 — and follows the repository title template by including the ticket link and type, making the intent clear to reviewers.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ea079fa and 4774dbe.

📒 Files selected for processing (1)

tests/integration/test_lists/waives.txt (1 hunks)

🧰 Additional context used

🧠 Learnings (5)

📓 Common learnings

Learnt from: tongyuantongyu
PR: NVIDIA/TensorRT-LLM#7781
File: tests/integration/test_lists/waives.txt:313-313
Timestamp: 2025-09-17T02:48:52.732Z
Learning: In TensorRT-LLM, `tests/integration/test_lists/waives.txt` is specifically for waiving/skipping tests, while other test list files like those in `test-db/` and `qa/` directories are for different test execution contexts (pre-merge, post-merge, QA tests). The same test appearing in both waives.txt and execution list files is intentional - the test is part of test suites but will be skipped due to the waiver.

📚 Learning: 2025-09-17T02:48:52.732Z

Learnt from: tongyuantongyu
PR: NVIDIA/TensorRT-LLM#7781
File: tests/integration/test_lists/waives.txt:313-313
Timestamp: 2025-09-17T02:48:52.732Z
Learning: In TensorRT-LLM, `tests/integration/test_lists/waives.txt` is specifically for waiving/skipping tests, while other test list files like those in `test-db/` and `qa/` directories are for different test execution contexts (pre-merge, post-merge, QA tests). The same test appearing in both waives.txt and execution list files is intentional - the test is part of test suites but will be skipped due to the waiver.

Applied to files:

tests/integration/test_lists/waives.txt

📚 Learning: 2025-08-29T14:07:45.863Z

Learnt from: EmmaQiaoCh
PR: NVIDIA/TensorRT-LLM#7370
File: tests/unittest/trt/model_api/test_model_quantization.py:24-27
Timestamp: 2025-08-29T14:07:45.863Z
Learning: In TensorRT-LLM's CI infrastructure, pytest skip markers (pytest.mark.skip) are properly honored even when test files have __main__ blocks that call test functions directly. The testing system correctly skips tests without requiring modifications to the __main__ block execution pattern.

Applied to files:

tests/integration/test_lists/waives.txt

📚 Learning: 2025-07-28T17:06:08.621Z

Learnt from: moraxu
PR: NVIDIA/TensorRT-LLM#6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.

Applied to files:

tests/integration/test_lists/waives.txt

📚 Learning: 2025-08-26T09:49:04.956Z

Learnt from: pengbowang-nv
PR: NVIDIA/TensorRT-LLM#7192
File: tests/integration/test_lists/test-db/l0_dgx_b200.yml:56-72
Timestamp: 2025-08-26T09:49:04.956Z
Learning: In TensorRT-LLM test configuration files, the test scheduling system handles wildcard matching with special rules that prevent duplicate test execution even when the same tests appear in multiple yaml files with overlapping GPU wildcards (e.g., "*b200*" and "*gb200*").

Applied to files:

tests/integration/test_lists/waives.txt

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Pre-commit Check

🔇 Additional comments (1)

tests/integration/test_lists/waives.txt (1)

351-351: Waiver verified — OK to keep.
Target test exists at tests/integration/defs/accuracy/test_llm_api_autodeploy.py (class TestLlama3_1_8B, def test_auto_dtype); no duplicate waiver found in tests/integration/test_lists/waives.txt.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

tensorrt-cicd · 2025-09-19T06:41:21Z

PR_Github #19302 [ skip ] triggered by Bot

tensorrt-cicd · 2025-09-19T06:41:23Z

PR_Github #19291 [ run ] completed with state ABORTED
LLM/main/L0_MergeRequest_PR #14489 (Blue Ocean) completed with status: ABORTED

tensorrt-cicd · 2025-09-19T06:54:56Z

PR_Github #19302 [ skip ] completed with state SUCCESS
Skipping testing for commit 4774dbe

NVIDIA#7853) Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com> Signed-off-by: Yanchao Lu <yanchaol@nvidia.com> Co-authored-by: Yanchao Lu <yanchaol@nvidia.com>

dominicshanshan requested a review from QiJune September 19, 2025 02:59

dominicshanshan requested a review from yuxianq September 19, 2025 03:28

yuxianq approved these changes Sep 19, 2025

View reviewed changes

dominicshanshan requested a review from EmmaQiaoCh September 19, 2025 05:52

Waive llama3 auto dtype test.

cb92d99

Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>

dominicshanshan force-pushed the user/shanshan/nv_bug_5527956_skip branch from 99d542a to cb92d99 Compare September 19, 2025 06:20

dominicshanshan requested a review from chzblych September 19, 2025 06:26

Update test_llm_api_autodeploy.py

4774dbe

Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>

chzblych approved these changes Sep 19, 2025

View reviewed changes

chzblych enabled auto-merge (squash) September 19, 2025 06:54

chzblych merged commit 451475e into NVIDIA:main Sep 19, 2025
7 checks passed

dominicshanshan deleted the user/shanshan/nv_bug_5527956_skip branch October 8, 2025 06:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[None][ci] Waive llama3 auto dtype test bug in https://nvbugs/5527956. #7853

[None][ci] Waive llama3 auto dtype test bug in https://nvbugs/5527956. #7853

Uh oh!

dominicshanshan commented Sep 19, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

dominicshanshan commented Sep 19, 2025

Uh oh!

dominicshanshan commented Sep 19, 2025

Uh oh!

dominicshanshan commented Sep 19, 2025

Uh oh!

tensorrt-cicd commented Sep 19, 2025

Uh oh!

chzblych commented Sep 19, 2025

Uh oh!

coderabbitai bot commented Sep 19, 2025

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Uh oh!

tensorrt-cicd commented Sep 19, 2025

Uh oh!

tensorrt-cicd commented Sep 19, 2025

Uh oh!

tensorrt-cicd commented Sep 19, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[None][ci] Waive llama3 auto dtype test bug in https://nvbugs/5527956. #7853

[None][ci] Waive llama3 auto dtype test bug in https://nvbugs/5527956. #7853

Uh oh!

Conversation

dominicshanshan commented Sep 19, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Description

Test Coverage

PR Checklist

GitHub Bot Help

kill

skip

reuse-pipeline

Uh oh!

dominicshanshan commented Sep 19, 2025

Uh oh!

dominicshanshan commented Sep 19, 2025

Uh oh!

dominicshanshan commented Sep 19, 2025

Uh oh!

tensorrt-cicd commented Sep 19, 2025

Uh oh!

chzblych commented Sep 19, 2025

Uh oh!

coderabbitai bot commented Sep 19, 2025

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Pre-merge checks and finishing touches

Uh oh!

tensorrt-cicd commented Sep 19, 2025

Uh oh!

tensorrt-cicd commented Sep 19, 2025

Uh oh!

tensorrt-cicd commented Sep 19, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dominicshanshan commented Sep 19, 2025 •

edited by coderabbitai bot

Loading