Skip to content

Conversation

@crazydemo
Copy link
Collaborator

@crazydemo crazydemo commented Sep 18, 2025

remove trt flow cases, low priority, and time consuming

Summary by CodeRabbit

  • Tests
    • Added new accuracy tests for DeepSeek V3 Lite across multiple PyTorch configurations to broaden coverage and validate behavior under varied runtime settings.
    • Removed several outdated Mixtral 8x7B accuracy tests to streamline the suite.
    • Result: Improved relevance and reliability of automated validation, aligning test coverage with current model support and reducing maintenance overhead.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 18, 2025

📝 Walkthrough

Walkthrough

Updated the QA test list for RTX6k: removed three Mixtral8x7B accuracy CLI-flow tests and added three DeepSeekV3Lite LLM-API PyTorch accuracy tests with bfloat16 and distinct single-flag variations for attention_dp and cuda_graph, keeping overlap_scheduler, torch_compile, and enable_chunked_prefill disabled.

Changes

Cohort / File(s) Summary of Changes
QA test list updates
tests/integration/test_lists/qa/llm_function_rtx6k.txt
Removed tests: Mixtral8x7B test_fp8_tp2pp2, test_fp8_tp2pp2_manage_weights, test_nvfp4_prequantized. Added tests: DeepSeekV3Lite LLM-API PyTorch test_bfloat16 with mtp_nextn=0 and single-flag variations for attention_dp and cuda_graph; overlap_scheduler=False, torch_compile=False, enable_chunked_prefill=False.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description does not follow the repository's required template: the title is not in the "[TICKET][type] Summary" format and the Description and Test Coverage sections are empty, containing only a terse note "remove trt flow cases, low priority, and time consuming." The provided pr_objectives and raw_summary show specific file/test changes (removal of three Mixtral CLI-flow tests and addition of three DeepSeekV3Lite tests) that are not documented in the PR body. Because the required template sections and concrete details (what changed, why, tests/CI impact, and ticket references) are missing, the description is incomplete and fails the check. Please update the PR to use the required title format, fill the Description with a concise summary of exact changes and rationale (which tests were removed/added and why), list Test Coverage and any CI/stage impact, and include related ticket/issue references and CODEOWNERS/documentation notes as applicable; you can paste the AI-generated summary from the raw_summary into the Description and verify the PR checklist before re-running checks.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title "[None][chore] remove cli cases for rtx6k" is concise, follows the repository tag format, and accurately describes the primary change—removal of CLI test cases for rtx6k—as reflected by the deletions in tests/integration/test_lists/qa/llm_function_rtx6k.txt, making it clear and appropriate for teammates scanning history.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@crazydemo crazydemo changed the title [None]remove cli cases for rtx6k [None][chore] remove cli cases for rtx6k Sep 18, 2025
@crazydemo
Copy link
Collaborator Author

/bot run --skip-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #19130 [ run ] triggered by Bot

@crazydemo crazydemo closed this Sep 18, 2025
@tensorrt-cicd
Copy link
Collaborator

PR_Github #19130 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #14354 (Partly Tested) completed with status: 'SUCCESS'

@crazydemo crazydemo reopened this Sep 19, 2025
Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com>
@crazydemo
Copy link
Collaborator Author

/bot run --skip-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #19246 [ run ] triggered by Bot

@StanleySun639 StanleySun639 enabled auto-merge (squash) September 19, 2025 02:25
@tensorrt-cicd
Copy link
Collaborator

PR_Github #19246 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #14454 (Partly Tested) completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@crazydemo
Copy link
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #19325 [ reuse-pipeline ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #19325 [ reuse-pipeline ] completed with state SUCCESS
Reusing PR_Github #19246 (Partly Tested) for commit 1c8254e

@StanleySun639 StanleySun639 merged commit 0ac5148 into NVIDIA:main Sep 19, 2025
5 checks passed
Wong4j pushed a commit to Wong4j/TensorRT-LLM that referenced this pull request Sep 20, 2025
Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com>
MrGeva pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request Sep 21, 2025
Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants