Skip to content

Conversation

@Superjomn
Copy link
Collaborator

@Superjomn Superjomn commented Sep 17, 2025

Summary by CodeRabbit

  • Tests
    • Re-enabled a set of previously skipped tests by removing waivers from the test-exclusion list.
    • Increases automated test coverage and strengthens quality assurance.
    • No changes to product functionality or user experience.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Signed-off-by: Yan Chunwei <328693+Superjomn@users.noreply.github.com>
@Superjomn
Copy link
Collaborator Author

/bot skip --comment "only changed waive list"

@Superjomn Superjomn enabled auto-merge (squash) September 17, 2025 09:50
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 17, 2025

📝 Walkthrough

Walkthrough

Removed four waiver lines from tests/integration/test_lists/waives.txt that previously skipped partitioned GPT attention tests, allowing those tests to run. No source code changes.

Changes

Cohort / File(s) Summary of Changes
Test waivers cleanup
tests/integration/test_lists/waives.txt
Deleted 4 skip entries for unittest/trt/attention/test_gpt_attention.py partitions 0–3 (nvbugs/5412456). No other edits.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description contains only the repository template text and a CodeRabbit AI placeholder without any concrete explanation of what changed, why it changed, or how to validate it; the Description, Test Coverage, and PR Checklist sections are left verbatim and unfilled. Because the body does not describe the waiver removals, list affected tests, or provide test/validation instructions, it is insufficient to judge the change and therefore fails this check. The author must provide substantive details before the PR can be approved. Please update the PR description by replacing the @coderabbitai placeholder with a concise Description that explains which waiver lines were removed and why, add a Test Coverage section listing relevant tests or CI stages that validate the change, and complete the PR Checklist items. Also include any related ticket or NVBugs ID in the title or body per the repository template and remove the verbatim template/help text. After these details are provided the description can be re-evaluated for approval.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title "[None][ci] restore unwaive list" follows the repository's title template style and concisely reflects the primary change shown in the diff: removal of waived entries from tests/integration/test_lists/waives.txt to re-enable four partition tests. It is short, specific to CI, and communicates the main intent so a teammate scanning history will understand the primary change. The wording could be slightly polished for clarity (e.g., "restore unwaived tests"), but it is acceptable as-is.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d3467f9 and ace3a8f.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt (0 hunks)
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@EmmaQiaoCh
Copy link
Collaborator

/bot run --stage-list "GH200-TensorRT-Post-Merge-1"

@Superjomn Superjomn disabled auto-merge September 17, 2025 09:55
@tensorrt-cicd
Copy link
Collaborator

PR_Github #18970 [ skip ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #18971 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #18970 [ skip ] completed with state ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #18971 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #14221 (Partly Tested) completed with status: 'SUCCESS'

@Superjomn
Copy link
Collaborator Author

/bot skip --comment "waive list change"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #19091 [ skip ] triggered by Bot

@Superjomn Superjomn enabled auto-merge (squash) September 18, 2025 02:42
@tensorrt-cicd
Copy link
Collaborator

PR_Github #19091 [ skip ] completed with state SUCCESS
Skipping testing for commit ace3a8f

@Superjomn Superjomn merged commit 327e5e5 into NVIDIA:main Sep 18, 2025
8 of 9 checks passed
@Superjomn Superjomn deleted the fix-unwaived branch September 18, 2025 03:07
Wong4j pushed a commit to Wong4j/TensorRT-LLM that referenced this pull request Sep 20, 2025
Signed-off-by: Yan Chunwei <328693+Superjomn@users.noreply.github.com>
MrGeva pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request Sep 21, 2025
Signed-off-by: Yan Chunwei <328693+Superjomn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants